fix: Build embedded UI from local source#6525
Merged
Merged
Conversation
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
make build-uito build the checked-outui/source and copy the generated build intosdk/python/feast/ui/build.build-ui-localas an alias for the same build path.Why
feast uipackages the embedded React app fromsdk/python/feast/ui/build. The previous release build target pulled@feast-dev/feast-ui --latestfrom npm, but npm's latest published package is still0.57.0. That stale UI treatsregistryPathas a monolithic registry blob URL, so with the newer Python server generating/api/v1, it requestsGET /api/v1and receives a 404.Building the embedded UI from the repo-local
ui/source keeps the frontend bundle aligned with the REST-backed Python UI server.Fixes #6519.
Validation
make -n build-uiI could not run the full UI build locally because
yarnis not installed in this shell.