Skip to content

test: Move universal offline/online/materialization tests to universal/ directory #6505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yashghatol wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test: Move universal offline/online/materialization tests to universal/ directory #6505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,8 +484,8 @@ test-python-universal-cassandra: ## Run Python Cassandra integration tests
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.cassandra_online_store.cassandra_repo_configuration \
PYTEST_PLUGINS=sdk.python.tests.universal.feature_repos.universal.online_store.cassandra \
python -m pytest -x --integration \
sdk/python/tests/integration/offline_store/test_feature_logging.py \
--ignore=sdk/python/tests/integration/offline_store/test_validation.py \
sdk/python/tests/universal/offline_store/test_feature_logging.py \
--ignore=sdk/python/tests/universal/offline_store/test_dqm_validation.py \
-k "not test_snowflake and \
not test_spark_materialization_consistency and \
not test_universal_materialization"
Expand Down Expand Up @@ -574,7 +574,7 @@ test-python-universal-milvus-online: ## Run Python Milvus online store integrati
PYTEST_PLUGINS=sdk.python.tests.universal.feature_repos.universal.online_store.milvus \
python -m pytest -n 8 --integration \
-k "test_retrieve_online_milvus_documents" \
sdk/python/tests --ignore=sdk/python/tests/integration/offline_store/test_dqm_validation.py
sdk/python/tests --ignore=sdk/python/tests/universal/offline_store/test_dqm_validation.py

test-python-universal-singlestore-online: ## Run Python Singlestore online store integration tests
PYTHONPATH='.' \
Expand All @@ -594,7 +594,7 @@ test-python-universal-qdrant-online: ## Run Python Qdrant online store integrati
PYTEST_PLUGINS=sdk.python.tests.universal.feature_repos.universal.online_store.qdrant \
python -m pytest -n 8 --integration \
-k "test_retrieve_online_documents" \
sdk/python/tests/integration/online_store/test_universal_online.py
sdk/python/tests/universal/online_store/test_universal_online.py

# To use Couchbase as an offline store, you need to create an Couchbase Capella Columnar cluster on cloud.couchbase.com.
# Modify environment variables COUCHBASE_COLUMNAR_CONNECTION_STRING, COUCHBASE_COLUMNAR_USER, and COUCHBASE_COLUMNAR_PASSWORD
Expand Down
2 changes: 1 addition & 1 deletion docs/how-to-guides/adding-or-reusing-tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ Docstring tests are primarily smoke tests to make sure imports and setup functio
Let's look at a sample test using the universal repo:

{% tabs %}
{% tab code="sdk/python/tests/integration/offline_store/test_universal_historical_retrieval.py" %}
{% tab code="sdk/python/tests/universal/offline_store/test_universal_historical_retrieval.py" %}
```python
@pytest.mark.integration
@pytest.mark.universal_offline_stores
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ Docstring tests are primarily smoke tests to make sure imports and setup functio
Let's look at a sample test using the universal repo:

{% tabs %}
{% tab code="sdk/python/tests/integration/offline_store/test_universal_historical_retrieval.py" %}
{% tab code="sdk/python/tests/universal/offline_store/test_universal_historical_retrieval.py" %}
```python
@pytest.mark.integration
@pytest.mark.universal_offline_stores
Expand Down
0 ...on/tests/universal/offline_store/.gitkeep → ...python/tests/integration/auth/__init__.py
View file
Open in desktop
File renamed without changes.
0 .../online_store/test_remote_online_store.py → ...egration/auth/test_remote_online_store.py
View file
Open in desktop
File renamed without changes.
0 .../online_store/test_hybrid_online_store.py → ...on/tests/unit/test_hybrid_online_store.py
View file
Open in desktop
File renamed without changes.
0 ...hon/tests/universal/online_store/.gitkeep → ...sts/universal/materialization/__init__.py
View file
Open in desktop
File renamed without changes.
0 ...ization/test_universal_materialization.py → ...ization/test_universal_materialization.py
View file
Open in desktop
File renamed without changes.
Empty file added sdk/python/tests/universal/offline_store/__init__.py
View file
Open in desktop
Empty file.
0 ...tion/offline_store/test_dqm_validation.py → ...rsal/offline_store/test_dqm_validation.py
View file
Open in desktop
File renamed without changes.
0 ...ion/offline_store/test_feature_logging.py → ...sal/offline_store/test_feature_logging.py
View file
Open in desktop
File renamed without changes.
0 ...ion/offline_store/test_non_entity_mode.py → ...sal/offline_store/test_non_entity_mode.py
View file
Open in desktop
File renamed without changes.
0 ...ation/offline_store/test_offline_write.py → ...ersal/offline_store/test_offline_write.py
View file
Open in desktop
File renamed without changes.
0 ...integration/offline_store/test_persist.py → ...s/universal/offline_store/test_persist.py
View file
Open in desktop
File renamed without changes.
0 ...re/test_push_features_to_offline_store.py → ...re/test_push_features_to_offline_store.py
View file
Open in desktop
File renamed without changes.
0 ...re/test_universal_historical_retrieval.py → ...re/test_universal_historical_retrieval.py
View file
Open in desktop
File renamed without changes.
0 ...e_store/test_universal_materialization.py → ...e_store/test_universal_materialization.py
View file
Open in desktop
File renamed without changes.
0 ...ion/offline_store/test_universal_types.py → ...sal/offline_store/test_universal_types.py
View file
Open in desktop
File renamed without changes.
Empty file added sdk/python/tests/universal/online_store/__init__.py
View file
Open in desktop
Empty file.
0 ...ore/test_push_features_to_online_store.py → ...ore/test_push_features_to_online_store.py
View file
Open in desktop
File renamed without changes.
0 ...ration/online_store/test_universal_e2e.py → ...versal/online_store/test_universal_e2e.py
View file
Open in desktop
File renamed without changes.
0 ...ion/online_store/test_universal_online.py → ...sal/online_store/test_universal_online.py
View file
Open in desktop
File renamed without changes.
0 ...line_store/test_universal_online_types.py → ...line_store/test_universal_online_types.py
View file
Open in desktop
File renamed without changes.