test: Move universal offline/online/materialization tests to universal/ directory#6505
Open
yashghatol wants to merge 1 commit into
Open
test: Move universal offline/online/materialization tests to universal/ directory#6505yashghatol wants to merge 1 commit into
yashghatol wants to merge 1 commit into
Conversation
…l/ directory Relocates cross-backend parameterized tests from integration/ into the 4-tier folder structure proposed in feast-dev#6048. Moves: - integration/offline_store/ (10 files) -> universal/offline_store/ - integration/online_store/test_universal_{e2e,online,online_types}.py + test_push_features_to_online_store.py -> universal/online_store/ - integration/online_store/test_hybrid_online_store.py -> unit/ (uses unittest.mock only, no real services) - integration/online_store/test_remote_online_store.py -> integration/permissions/auth/ (auth-scoped, not universal) - integration/materialization/test_universal_materialization.py -> universal/materialization/ Also updates stale path references in: - Makefile (4 paths: cassandra, milvus, qdrant targets) - docs/how-to-guides/adding-or-reusing-tests.md - sdk/python/tests/README.md Closes feast-dev#6051 Signed-off-by: yashghatol <yashghatol822@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Relocates cross-backend parameterized tests from
sdk/python/tests/integration/*into dedicatedsdk/python/tests/universal/*directories, aligning the test suite with the 4-tier taxonomy proposed in #6048.No test logic or behavior changes are introduced.
universal/offline_store/
Move all 10 test files from
integration/offline_store/.These tests use the shared environment fixture and are marked with
@pytest.mark.universal_offline_stores, confirming that they run across multiple backend implementations.universal/online_store/
Move the following files from
integration/online_store/:test_universal_e2e.pytest_universal_online.pytest_universal_online_types.pytest_push_features_to_online_store.pyuniversal/materialization/
Move:
test_universal_materialization.pyfrom
integration/materialization/.Outlier corrections
Move tests that do not belong in the universal layer:
test_hybrid_online_store.py→unit/unittest.mocktest_remote_online_store.py→integration/permissions/auth/Reference updates
Update references impacted by the test relocation:
Fix 4 stale paths in
MakefileCorrect filename:
test_validation.py→test_dqm_validation.pyUpdate:
docs/how-to-guides/adding-or-reusing-tests.mdsdk/python/tests/README.mdWhich issue(s) this PR fixes
Closes #6051
Does this PR introduce a user-facing change?
NONE
Checks
git commit -s)Testing Strategy
Unit tests (
make test-python-unit)Integration tests
Manual tests
Testing is not required for this change
Additional Notes
This is my first contribution to Feast, so please let me know if there's anything I've overlooked or if you'd prefer a different approach.