-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: Add version tracking to FeatureView #6101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
a90cb7f
feat: Add version tracking to FeatureView, StreamFeatureView, and OnD…
franciscojavierarceo f28942b
fix: Address PR review feedback from Devin
franciscojavierarceo 171785e
docs: Add feature view versioning documentation
franciscojavierarceo f035e96
fix: Address second round of PR review feedback from Devin
franciscojavierarceo 0c12655
fix: Clean up version history on delete and use write_engine consiste…
franciscojavierarceo d32ed52
docs: Clarify versioning auto-increment behavior and pin/revert flow
franciscojavierarceo f9e896f
fix: Add pin conflict detection to both file and SQL registries
franciscojavierarceo 2069b22
fix: Address Devin review feedback on versioning
franciscojavierarceo 83393aa
docs: Document concurrent multi-version serving limitations
franciscojavierarceo 94afe6e
feat: Implement version-qualified feature references (@v<N>)
franciscojavierarceo 76d1afc
fix: Resolve mypy type errors in proto_registry_utils.py
franciscojavierarceo 2541e41
feat: Add version metadata to clean @v2 syntax from feature names
franciscojavierarceo bceb052
fix: Update provider implementations with version metadata parameter
franciscojavierarceo 14b2da0
fix: Add version metadata parameter to all online store implementations
franciscojavierarceo fd776fc
fix: Resolve mypy type errors in versioning code
franciscojavierarceo e9c4c68
fix: Address Devin review feedback on versioning
franciscojavierarceo 903bda5
fix: Address additional Devin review feedback
franciscojavierarceo af47911
Merge branch 'master' into featureview-versioning
franciscojavierarceo dd31cdb
feat: Make feature view versioning opt-in via registry config
franciscojavierarceo 8809805
fix: Address Devin review feedback on versioning issues
franciscojavierarceo d23c4bb
fix: Preserve version tag in response column names for multi-version …
franciscojavierarceo c5d4b49
feat: Handle version race conditions gracefully with retry and forwar…
franciscojavierarceo 2a3e544
feat: Gate feature services that reference versioned feature views
franciscojavierarceo 66c280b
fix: Resolve mypy errors and rename config field for clarity
franciscojavierarceo cfc038b
feat: Enable feature service serving for versioned feature views
franciscojavierarceo c9aea43
docs: Update RFC for feature service support and rename CLI command
franciscojavierarceo 221e0ed
feat(ui): Add version display and Versions tab to feature view pages
franciscojavierarceo 3efccbf
style(ui): Fix prettier formatting in feature view components
franciscojavierarceo 6878fb0
updated utcnow
franciscojavierarceo 280daf6
feat: Add version-aware materialization support
franciscojavierarceo 43674ac
fix: Resolve three versioning regressions from review feedback
franciscojavierarceo 01e4e77
feat: Add --no-promote flag to feast apply and fix versioned ref parsing
franciscojavierarceo 1876060
docs: Consolidate versioning docs into alpha reference page
franciscojavierarceo 760c003
docs: Add no_promote to apply_diff_to_registry docstring
franciscojavierarceo bc986ef
fix: Reject reserved chars in FV names and make version parser resilient
franciscojavierarceo b2d6c09
Merge branch 'master' into featureview-versioning
franciscojavierarceo 3a73c87
fix: Add ensure_valid() call in Snowflake registry apply_feature_view
franciscojavierarceo 1468bc5
Merge branch 'master' into featureview-versioning
franciscojavierarceo 3c1ddbe
fix: Make version_tag optional in proto and use HasField() for correc…
franciscojavierarceo 8c1259f
fix: Address versioning review feedback (Snowflake, Go server, SQL re…
franciscojavierarceo ac0348d
Merge branch 'master' into featureview-versioning
franciscojavierarceo 7dfc447
fix: Handle @latest in Go feature server and pre-compile version regex
franciscojavierarceo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: Implement version-qualified feature references (@v<N>)
Extends feature view versioning with support for reading features from specific
versions at query time using the syntax: "driver_stats@v2:trips_today"
Core changes:
- Add _parse_feature_ref() to parse version-qualified feature references
- Update all feature reference parsing to use _parse_feature_ref()
- Add get_feature_view_by_version() to BaseRegistry and all implementations
- Add FeatureViewProjection.version_tag for multi-version query support
- Add version-aware _table_id() in SQLite online store (v0→unversioned, v1+→_v{N})
- Add VersionedOnlineReadNotSupported error for unsupported stores
Features:
- "driver_stats:trips" = "driver_stats@latest:trips" (backward compatible)
- "driver_stats@v2:trips" reads from v2 snapshot using _v2 table suffix
- Multiple versions in same query: ["driver@v1:trips", "driver@v2:daily"]
- Version parameter added to all decorator functions for consistency
Backward compatibility:
- Unversioned table serves as v0, only v1+ get _v{N} suffix
- All existing queries work unchanged
- SQLite-only for now, other stores raise clear error
Documentation:
- Updated feature-view.md with @Version syntax examples
- Updated feature-retrieval.md reference format
- Added version examples to how-to guides
Tests: 47 unit + 11 integration tests pass, no regressions
Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>- Loading branch information
commit 94afe6ef61aedb0c808097f80a3b9c6cebe7aef6
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
devin-ai-integration[bot] marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
although unlikely, it can still happen that a feature name has a
@, will the apply be able to identify and abort safely?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added validation for this so that new
feast applywith@in the feature view names are rejected but old ones are used.For the latter case we have to make some assumptions about format because we support
@vN,@versionN, and@latestso those rare edge cases could cause headaches but we've documented it. Thanks for calling it out!