fix: Address versioning review feedback (Snowflake, Go server, SQL re…

…gistry) - Snowflake registry: raise NotImplementedError when no_promote=True since versioning is not supported - Go feature server: return error on versioned refs (@vn) instead of silently stripping the version and serving unversioned data - SQL registry: inline delete logic in delete_feature_view so the FV delete and version history cleanup run in a single transaction, preventing orphaned rows on partial failure Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
feast-dev · franciscojavierarceo · Mar 26, 2026 · Mar 12, 2026 · Mar 12, 2026 · Mar 13, 2026
commit 8c1259fb6a1ff888476169e6e503e396bafc6f28
@@ -494,12 +494,13 @@ func ParseFeatureReference(featureRef string) (featureViewName, featureName stri
 		featureName = parsedFeatureName[1]
 	}
 
-	// Strip @v<N> version qualifier from feature view name
+	// Reject @v<N> version qualifier — Go feature server does not support versioned reads
 	if atIdx := strings.Index(featureViewName, "@"); atIdx >= 0 {
 		suffix := featureViewName[atIdx+1:]
 		matched, _ := regexp.MatchString(`^[vV]\d+$`, suffix)
 		if matched {
-			featureViewName = featureViewName[:atIdx]
+			e = fmt.Errorf("versioned feature refs (@%s) are not supported by the Go feature server", suffix)
+			return
 		}
 	}
 	return

@@ -265,6 +265,11 @@ def apply_feature_view(
         commit: bool = True,
         no_promote: bool = False,
     ):
+        if no_promote:
+            raise NotImplementedError(
+                "Feature view versioning (no_promote) is not supported by the Snowflake registry. "
+                "Use the SQL registry or file registry for versioning support."
+            )
         feature_view.ensure_valid()
         fv_table_str = self._infer_fv_table(feature_view)
         fv_column_name = fv_table_str[:-1]

@@ -561,25 +561,37 @@ def delete_entity(self, name: str, project: str, commit: bool = True):
         )
 
     def delete_feature_view(self, name: str, project: str, commit: bool = True):
-        deleted_count = 0
-        for table in {
-            feature_views,
-            on_demand_feature_views,
-            stream_feature_views,
-        }:
-            deleted_count += self._delete_object(
-                table, name, project, "feature_view_name", None
-            )
-        if deleted_count == 0:
-            raise FeatureViewNotFoundException(name, project)
-        # Clean up version history for the deleted feature view
         with self.write_engine.begin() as conn:
+            deleted_count = 0
+            for table in {
+                feature_views,
+                on_demand_feature_views,
+                stream_feature_views,
+            }:
+                stmt = delete(table).where(
+                    table.c.feature_view_name == name,
+                    table.c.project_id == project,
+                )
+                rows = conn.execute(stmt)
+                deleted_count += rows.rowcount
+            if deleted_count == 0:
+                raise FeatureViewNotFoundException(name, project)
+            # Clean up version history in the same transaction
             stmt = delete(feature_view_version_history).where(
                 feature_view_version_history.c.feature_view_name == name,
                 feature_view_version_history.c.project_id == project,
             )
             conn.execute(stmt)
 
+        self.apply_project(
+            self.get_project(name=project, allow_cache=False), commit=True
+        )
+        if not self.purge_feast_metadata:
+            with self.write_engine.begin() as conn:
+                self._set_last_updated_metadata(_utc_now(), project, conn)
+        if self.cache_mode == "sync":
+            self.refresh()
+
     def delete_feature_service(self, name: str, project: str, commit: bool = True):
         return self._delete_object(
             feature_services,