Skip to content

feat: Making feature view source optional (feast-dev#6074) #6075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 9 commits into from
Mar 10, 2026
Merged

feat: Making feature view source optional (feast-dev#6074) #6075

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4d64118
feat: Making feature view source optional (feast-dev#6074)
nickquinn408 Mar 7, 2026
33d5801
Fixing when source is used
nickquinn408 Mar 7, 2026
38dc272
Devin feedback response
nickquinn408 Mar 7, 2026
fe5c0b0
Fixing linter issues
nickquinn408 Mar 7, 2026
f6ba8f9
Fixing broken test
nickquinn408 Mar 7, 2026
6eb4874
More feedback
nickquinn408 Mar 8, 2026
6d31b28
Update sdk/python/feast/batch_feature_view.py
nquinn408 Mar 8, 2026
df4c9e8
Adding integration for feature view with no source
nickquinn408 Mar 9, 2026
e180bb0
Fix lint-python issue
nickquinn408 Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixing broken test 
Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
  • Loading branch information
@nickquinn408 @ntkathole
nickquinn408 authored and ntkathole committed Mar 10, 2026
commit f6ba8f901bbdbbf146b989b6152014a1f2a01b62
10 changes: 10 additions & 0 deletions sdk/python/feast/batch_feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,16 @@ def __init__(
f"or CUSTOM_SOURCE, got {type(source).__name__}: {source.name} instead "
)

if (
source is None
and not udf
and not feature_transformation
and not aggregations
):
raise ValueError(
"BatchFeatureView requires at least one of: source, udf, feature_transformation, or aggregations."
)
Comment thread
nquinn408 marked this conversation as resolved.

self.mode = mode
self.udf = udf
self.udf_string = udf_string
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/unit/test_feature_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def test_create_batch_feature_view():
udf=lambda x: x,
)

with pytest.raises(TypeError):
with pytest.raises(ValueError):
BatchFeatureView(
name="test batch feature view", entities=[], ttl=timedelta(days=30)
)
Expand Down