Skip to content

feat: Making feature view source optional (feast-dev#6074) #6075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 9 commits into from
Mar 10, 2026
Merged

feat: Making feature view source optional (feast-dev#6074) #6075

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4d64118
feat: Making feature view source optional (feast-dev#6074)
nickquinn408 Mar 7, 2026
33d5801
Fixing when source is used
nickquinn408 Mar 7, 2026
38dc272
Devin feedback response
nickquinn408 Mar 7, 2026
fe5c0b0
Fixing linter issues
nickquinn408 Mar 7, 2026
f6ba8f9
Fixing broken test
nickquinn408 Mar 7, 2026
6eb4874
More feedback
nickquinn408 Mar 8, 2026
6d31b28
Update sdk/python/feast/batch_feature_view.py
nquinn408 Mar 8, 2026
df4c9e8
Adding integration for feature view with no source
nickquinn408 Mar 9, 2026
e180bb0
Fix lint-python issue
nickquinn408 Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Devin feedback response 
Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
  • Loading branch information
@nickquinn408 @ntkathole
nickquinn408 authored and ntkathole committed Mar 10, 2026
commit 38dc2722c54df32a93531f2ec9af8ae663bf9405
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/passthrough_provider.py
View file
Open in desktop
Comment thread
nquinn408 marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ def _prep_rows_to_write_for_ingestion(
# Note: A dictionary mapping of column names in this data
# source to feature names in a feature table or view. Only used for feature
# columns, not entity or timestamp columns.
if hasattr(feature_view, "batch_source"):
if hasattr(feature_view, "batch_source") and feature_view.batch_source is not None:
if feature_view.batch_source.field_mapping is not None:
table = _run_pyarrow_field_mapping(
table, feature_view.batch_source.field_mapping
Expand Down
5 changes: 2 additions & 3 deletions sdk/python/feast/repo_operations.py
View file
Open in desktop
Comment thread
nquinn408 marked this conversation as resolved.
Comment thread
nquinn408 marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,7 @@ def parse_repo(repo_root: Path) -> RepoContents:

# Handle batch sources defined with feature views.
batch_source = obj.batch_source
assert batch_source
if not any((batch_source is ds) for ds in res.data_sources):
if batch_source is not None and not any((batch_source is ds) for ds in res.data_sources):
res.data_sources.append(batch_source)

# Handle stream sources defined with feature views.
Expand Down Expand Up @@ -232,7 +231,7 @@ def plan(
# TODO: When we support multiple projects in a single repo, we should filter repo contents by project
if not skip_source_validation:
provider = store._get_provider()
data_sources = [t.batch_source for t in repo.feature_views]
data_sources = [t.batch_source for t in repo.feature_views if t.batch_source is not None]
# Make sure the data source used by this feature view is supported by Feast
for data_source in data_sources:
provider.validate_data_source(store.config, data_source)
Expand Down