Skip to content

feat: Support arm docker build #6061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 6 commits into from
Mar 7, 2026
Merged

feat: Support arm docker build #6061

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c9dc059
feat: support arm docker build
Anarion-zuo Mar 4, 2026
e3cd924
docker ci test
Anarion-zuo Mar 4, 2026
ea8f978
support dev
Anarion-zuo Mar 5, 2026
3455c02
publish feature-server-dev
Anarion-zuo Mar 5, 2026
82a7265
master_only trigger
Anarion-zuo Mar 6, 2026
5cba559
master_only docker build use make
Anarion-zuo Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
support dev 
Signed-off-by: aaronzuo <anarionzuo@outlook.com>
  • Loading branch information
@Anarion-zuo @ntkathole
Anarion-zuo authored and ntkathole committed Mar 6, 2026
commit ea8f9787605f918c3331e09f53c3be6404b69d25
48 changes: 48 additions & 0 deletions .github/workflows/docker_smoke_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:
- "infra/scripts/feature_server_docker_smoke.py"
- "Makefile"
- ".github/workflows/publish_images.yml"
Copy link
Copy Markdown
Member

@ntkathole ntkathole Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also .github/workflows/docker_smoke_tests.yml

Copy link
Copy Markdown
Contributor Author

@Anarion-zuo Anarion-zuo Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

- ".github/workflows/docker_smoke_tests.yml"
workflow_dispatch:

concurrency:
Expand Down Expand Up @@ -62,3 +63,50 @@ jobs:
ARCH: ${{ matrix.arch }}
run: |
docker stop feature-server-smoke-${ARCH} || true
feature-server-dev-docker-smoke:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
arch: [amd64, arm64]
steps:
- uses: actions/checkout@v4
- name: Set up QEMU
uses: docker/setup-qemu-action@v3
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
with:
install: true
- name: Build feature-server-dev image
env:
ARCH: ${{ matrix.arch }}
run: |
make build-feature-server-dev-docker REGISTRY=feastdev VERSION=smoke-${ARCH} DOCKER_PLATFORMS=linux/${ARCH}
- name: Run container
env:
ARCH: ${{ matrix.arch }}
run: |
docker run -d --rm \
--name feature-server-dev-smoke-${ARCH} \
--platform linux/${ARCH} \
-p 6566:6566 \
-v "${GITHUB_WORKSPACE}/infra/scripts/feature_server_docker_smoke.py:/smoke.py:ro" \
feastdev/feature-server:smoke-${ARCH} \
python /smoke.py
- name: Wait for /health
run: |
for i in $(seq 1 60); do
if curl -fsS http://localhost:6566/health >/dev/null; then
exit 0
fi
sleep 2
done
echo "feature-server /health did not become ready"
docker logs feature-server-dev-smoke-${{ matrix.arch }} || true
exit 1
- name: Cleanup
if: always()
env:
ARCH: ${{ matrix.arch }}
run: |
docker stop feature-server-dev-smoke-${ARCH} || true
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,9 +715,9 @@ build-feature-server-dev: ## Build Feature Server Dev Docker image
-f sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev --load .

build-feature-server-dev-docker: ## Build Feature Server Dev Docker image
docker buildx build \
docker buildx build $(if $(DOCKER_PLATFORMS),--platform $(DOCKER_PLATFORMS),) \
-t $(REGISTRY)/feature-server:$(VERSION) \
-f sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev --load .
-f sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev $(if $(filter true,$(DOCKER_PUSH)),--push,--load) .

build-feature-server-dev-docker_on_mac: ## Build Feature Server Dev Docker image on Mac
docker buildx build --platform linux/amd64 \
Expand Down