Skip to content

feat: Support arm docker build #6061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 6 commits into from
Mar 7, 2026
Merged

feat: Support arm docker build #6061

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c9dc059
feat: support arm docker build
Anarion-zuo Mar 4, 2026
e3cd924
docker ci test
Anarion-zuo Mar 4, 2026
ea8f978
support dev
Anarion-zuo Mar 5, 2026
3455c02
publish feature-server-dev
Anarion-zuo Mar 5, 2026
82a7265
master_only trigger
Anarion-zuo Mar 6, 2026
5cba559
master_only docker build use make
Anarion-zuo Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
publish feature-server-dev 
Signed-off-by: aaronzuo <anarionzuo@outlook.com>
  • Loading branch information
@Anarion-zuo @ntkathole
Anarion-zuo authored and ntkathole committed Mar 6, 2026
commit 3455c0233de88812f9ddc41d6d11be9591c5b268
14 changes: 11 additions & 3 deletions .github/workflows/master_only.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,20 @@ jobs:
password: ${{ secrets.QUAYIO_CI_TOKEN }}
- name: Build image
run: |
make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA}
if [[ "${{ matrix.component }}" == "feature-server-dev" ]]; then
Copy link
Copy Markdown
Member

@ntkathole ntkathole Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep using make target, this avoids little maintenance for future

- name: Build image
     run: |
       if [[ "${{ matrix.component }}" == "feature-server-dev" ]]; then
         make build-feature-server-dev-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA} DOCKER_PUSH=true DOCKER_PLATFORMS=linux/amd64,linux/arm64
       else
         make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA}
       fi
   - name: Push image
     run: |
       if [[ "${{ matrix.component }}" == "feature-server-dev" ]]; then
         docker buildx imagetools create -t ${REGISTRY}/feature-server:develop ${REGISTRY}/feature-server:${GITHUB_SHA}
       else
         docker tag ${REGISTRY}/${{ matrix.component }}:${GITHUB_SHA} ${REGISTRY}/${{ matrix.component }}:develop
         docker push ${REGISTRY}/${{ matrix.component }} --all-tags
       fi

Copy link
Copy Markdown
Contributor Author

@Anarion-zuo Anarion-zuo Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified the 'Build image' part to make one-liners.

docker buildx build \
--platform linux/amd64,linux/arm64 \
-t ${REGISTRY}/feature-server:${GITHUB_SHA} \
-t ${REGISTRY}/feature-server:develop \
-f sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev \
--push .
else
make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA}
fi
- name: Push image
run: |
if [[ "${{ matrix.component }}" == "feature-server-dev" ]]; then
docker tag ${REGISTRY}/feature-server:${GITHUB_SHA} ${REGISTRY}/feature-server:develop
docker push ${REGISTRY}/feature-server --all-tags
echo "feature-server dev image pushed via buildx during build step"
else
docker tag ${REGISTRY}/${{ matrix.component }}:${GITHUB_SHA} ${REGISTRY}/${{ matrix.component }}:develop
docker push ${REGISTRY}/${{ matrix.component }} --all-tags
Expand Down