Skip to content

feat: Adjust ray offline store to support abfs(s) ADLS Azure Storage #5911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 8 commits into from
Jan 30, 2026
Merged

feat: Adjust ray offline store to support abfs(s) ADLS Azure Storage #5911

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d07896c
feat: adjust ray offline store to support abfs(s) ADLS Azure Storage
p3s-jbauer Jan 27, 2026
3de9dcd
Delete test_registry file.
p3s-jbauer Jan 27, 2026
a5dc522
Feedback from PR Review.
p3s-jbauer Jan 27, 2026
9c140c7
Added additional comment about env var.
p3s-jbauer Jan 27, 2026
f57b172
Fixed potential issue from PR.
p3s-jbauer Jan 28, 2026
ce98866
Fixed found issue by Devin from PR.
p3s-jbauer Jan 29, 2026
7f1d005
Apply formatting
p3s-jbauer Jan 29, 2026
74967ba
Fixed found issue by Devin from PR.
p3s-jbauer Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed potential issue from PR. 
Signed-off-by: Jonas Bauer <jbauer@easy2parts.com>
  • Loading branch information
@p3s-jbauer @ntkathole
p3s-jbauer authored and ntkathole committed Jan 30, 2026
commit f57b172be2340f34220d469de594dc6a8002229b
5 changes: 4 additions & 1 deletion sdk/python/feast/infra/compute_engines/ray/job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
from feast.infra.compute_engines.dag.model import DAGFormat
from feast.infra.compute_engines.dag.plan import ExecutionPlan
from feast.infra.compute_engines.dag.value import DAGValue
from feast.infra.offline_stores.contrib.ray_offline_store.ray import (
REMOTE_STORAGE_SCHEMES,
)
from feast.infra.offline_stores.file_source import SavedDatasetFileStorage
from feast.infra.offline_stores.offline_store import RetrievalJob, RetrievalMetadata
from feast.infra.ray_initializer import get_ray_wrapper
Expand Down Expand Up @@ -205,7 +208,7 @@ def persist(
destination_path = storage.file_options.uri

# Check if destination already exists
if not destination_path.startswith(("s3://", "gs://", "hdfs://")):
if not destination_path.startswith(REMOTE_STORAGE_SCHEMES):
import os

if not allow_overwrite and os.path.exists(destination_path):
Expand Down