Skip to content

feat: Adjust ray offline store to support abfs(s) ADLS Azure Storage #5911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 8 commits into from
Jan 30, 2026
+30 −9
Merged

feat: Adjust ray offline store to support abfs(s) ADLS Azure Storage #5911

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d07896c
feat: adjust ray offline store to support abfs(s) ADLS Azure Storage
p3s-jbauer Jan 27, 2026
3de9dcd
Delete test_registry file.
p3s-jbauer Jan 27, 2026
a5dc522
Feedback from PR Review.
p3s-jbauer Jan 27, 2026
9c140c7
Added additional comment about env var.
p3s-jbauer Jan 27, 2026
f57b172
Fixed potential issue from PR.
p3s-jbauer Jan 28, 2026
ce98866
Fixed found issue by Devin from PR.
p3s-jbauer Jan 29, 2026
7f1d005
Apply formatting
p3s-jbauer Jan 29, 2026
74967ba
Fixed found issue by Devin from PR.
p3s-jbauer Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: adjust ray offline store to support abfs(s) ADLS Azure Storage 
Signed-off-by: Jonas Bauer <jbauer@easy2parts.com>
  • Loading branch information
@p3s-jbauer @ntkathole
p3s-jbauer authored and ntkathole committed Jan 30, 2026
commit d07896c1e0e33b5d91e413ebad53c163f812e9d6
10 changes: 7 additions & 3 deletions sdk/python/feast/infra/offline_stores/contrib/ray_offline_store/ray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1160,13 +1160,17 @@ def persist(
f"Ray offline store only supports SavedDatasetFileStorage, got {type(storage)}"
)
destination_path = storage.file_options.uri
if not destination_path.startswith(("s3://", "gs://", "hdfs://")):
if not destination_path.startswith(
("s3://", "gs://", "hdfs://", "abfs://", "abfss://")
Copy link
Copy Markdown
Member

@ntkathole ntkathole Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

# Remote storage URI schemes supported by the Ray offline store
# S3: Amazon S3
# GCS: Google Cloud Storage
# HDFS: Hadoop Distributed File System
# Azure: Azure Storage Gen2
REMOTE_STORAGE_SCHEMES = ("s3://", "gs://", "hdfs://", "abfs://", "abfss://")

Can we define a constant for supported remote storage URI schemes at top and use it later at all three locations?

):
if not allow_overwrite and os.path.exists(destination_path):
raise SavedDatasetLocationAlreadyExists(location=destination_path)
try:
ray_ds = self._get_ray_dataset()

if not destination_path.startswith(("s3://", "gs://", "hdfs://")):
if not destination_path.startswith(
("s3://", "gs://", "hdfs://", "abfs://", "abfss://")
):
os.makedirs(os.path.dirname(destination_path), exist_ok=True)

ray_ds.write_parquet(destination_path)
Expand Down Expand Up @@ -1959,7 +1963,7 @@ def normalize_timestamps(batch: pd.DataFrame) -> pd.DataFrame:
path_obj = Path(resolved_path)
if path_obj.suffix == ".parquet":
path_obj = path_obj.with_suffix("")
if not absolute_path.startswith(("s3://", "gs://")):
if not absolute_path.startswith(("s3://", "gs://", "abfs://", "abfss://")):
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Outdated
path_obj.mkdir(parents=True, exist_ok=True)
ds.write_parquet(str(path_obj))
except Exception as e:
Expand Down
1 change: 1 addition & 0 deletions test_registry
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1"$da30d864-b635-49a1-aa21-43386ad9101b* ԩ������