fix: Address mypy and ruff lint errors in dbt integration

Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
feast-dev · franciscojavierarceo · Jan 16, 2026 · Jan 10, 2026 · Jan 10, 2026 · Jan 10, 2026
commit d20962d0b4592cf59cf430d6facce0348e2f7e00
@@ -5,7 +5,7 @@
 dbt models with Feast feature stores.
 """
 
-from typing import List, Optional
+from typing import Any, Dict, List, Optional
 
 import click
 from colorama import Fore, Style
@@ -119,8 +119,8 @@ def import_command(
         # Generate Python file instead of applying to registry
         feast dbt import -m target/manifest.json -e driver_id --tag feast --output features.py
     """
-    from feast.dbt.parser import DbtManifestParser
     from feast.dbt.mapper import DbtToFeastMapper
+    from feast.dbt.parser import DbtManifestParser
 
     # Parse manifest
     click.echo(f"{Fore.CYAN}Parsing dbt manifest: {manifest_path}{Style.RESET_ALL}")
@@ -177,8 +177,8 @@ def import_command(
     # Generate Feast objects
     click.echo(f"\n{Fore.CYAN}Generating Feast objects...{Style.RESET_ALL}")
 
-    all_objects = []
-    entities_created = {}
+    all_objects: List[Any] = []
+    entities_created: Dict[str, Any] = {}
 
     for model in models:
         # Validate timestamp field exists
@@ -202,7 +202,7 @@ def import_command(
         if entity_column not in entities_created:
             entity = mapper.create_entity(
                 name=entity_column,
-                description=f"Entity key for dbt models",
+                description="Entity key for dbt models",
             )
             entities_created[entity_column] = entity
             all_objects.append(entity)
@@ -274,7 +274,7 @@ def import_command(
         click.echo(
             f"\n{Fore.GREEN}✓ Generated Feast definitions: {output}{Style.RESET_ALL}"
         )
-        click.echo(f"  You can now import this file in your feature_store.yaml repo.")
+        click.echo("  You can now import this file in your feature_store.yaml repo.")
         return
 
     if dry_run:

@@ -15,9 +15,9 @@
     ...     feature_view = mapper.create_feature_view(model, data_source, "driver_id")
 """
 
-from feast.dbt.parser import DbtManifestParser, DbtModel, DbtColumn
-from feast.dbt.mapper import DbtToFeastMapper
 from feast.dbt.codegen import DbtCodeGenerator, generate_feast_code
+from feast.dbt.mapper import DbtToFeastMapper
+from feast.dbt.parser import DbtColumn, DbtManifestParser, DbtModel
 
 __all__ = [
     "DbtManifestParser",

@@ -7,10 +7,10 @@
 
 from typing import Any, List, Optional, Set
 
-from jinja2 import Environment, BaseLoader
+from jinja2 import BaseLoader, Environment
 
-from feast.dbt.parser import DbtModel
 from feast.dbt.mapper import map_dbt_type_to_feast_type
+from feast.dbt.parser import DbtModel
 from feast.types import (
     Array,
     Bool,
@@ -23,7 +23,6 @@
     UnixTimestamp,
 )
 
-
 # Template for generating a complete Feast definitions file
 FEAST_FILE_TEMPLATE = '''"""
 Feast feature definitions generated from dbt models.
@@ -239,7 +238,7 @@ def generate(
             "var_name": entity_var,
             "name": entity_column,
             "join_key": entity_column,
-            "description": f"Entity key for dbt models",
+            "description": "Entity key for dbt models",
             "tags": {"source": "dbt"},
         })
 

@@ -12,20 +12,19 @@
 from feast.entity import Entity
 from feast.feature_view import FeatureView
 from feast.field import Field
-from feast.value_type import ValueType
 from feast.types import (
     Array,
     Bool,
     Bytes,
+    FeastType,
     Float32,
     Float64,
     Int32,
     Int64,
     String,
     UnixTimestamp,
-    FeastType,
 )
-
+from feast.value_type import ValueType
 
 # Comprehensive mapping from dbt/warehouse types to Feast types
 # Covers BigQuery, Snowflake, Redshift, PostgreSQL, and common SQL types

@@ -8,10 +8,10 @@
 """
 
 import json
+from dataclasses import dataclass, field
 from enum import property
 from pathlib import Path
 from typing import Any, Dict, List, Optional
-from dataclasses import dataclass, field
 
 
 @dataclass
@@ -134,6 +134,9 @@ def get_models(
         if self._raw_manifest is None:
             self.parse()
 
+        if self._raw_manifest is None:
+            return []
+
         models = []
         nodes = self._raw_manifest.get("nodes", {})