fix: Address Copilot code review comments for dbt integration

- mapper.py: Fix Array element type check to use set membership instead of incorrect isinstance() comparison - codegen.py: Add safe getattr() with fallback for Array.base_type access Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
feast-dev · franciscojavierarceo · Jan 16, 2026 · Jan 10, 2026 · Jan 10, 2026 · Jan 10, 2026
commit 55174a5a1b6b1c4b629696a4a5d651a9f7aa3f2d
@@ -123,8 +123,9 @@
 def _get_feast_type_name(feast_type: Any) -> str:
     """Get the string name of a Feast type for code generation."""
     if isinstance(feast_type, Array):
-        # Handle Array types
-        base_type_name = _get_feast_type_name(feast_type.base_type)
+        # Handle Array types - safely get base_type with fallback
+        base_type = getattr(feast_type, "base_type", String)
+        base_type_name = _get_feast_type_name(base_type)
         return f"Array({base_type_name})"
 
     # Map type objects to their names

@@ -110,7 +110,8 @@ def map_dbt_type_to_feast_type(dbt_type: str) -> FeastType:
         element_type_str = normalized[6:-1].strip()
         element_type = map_dbt_type_to_feast_type(element_type_str)
         # Array only supports primitive types
-        if isinstance(element_type, type(String)):
+        valid_array_types = {String, Int32, Int64, Float32, Float64, Bool, Bytes, UnixTimestamp}
+        if element_type in valid_array_types:
             return Array(element_type)
         return Array(String)  # Fallback for complex nested types