Skip to content

feat: Allow to set registry server rest/grpc mode in operator #5364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tchughesiv merged 18 commits into from
Jun 13, 2025
Merged

feat: Allow to set registry server rest/grpc mode in operator #5364

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e67fc0d
feat: Allow to set registry server rest/grpc mode in operator
ntkathole May 16, 2025
ef5d3c4
Apply suggestions from code review
ntkathole May 21, 2025
7bcb688
chore: rename RestAPIEnabled to RestAPI
ntkathole May 21, 2025
0cedd49
test: Added test to verify registry with REST API enabled
ntkathole May 21, 2025
38dc1f8
test: Extend test to assert rest-api container args
ntkathole May 21, 2025
f70ba9b
feat: Added both grpc and rest flags
ntkathole Jun 10, 2025
06f559c
feat: Support seperate ports and service for rest-api
ntkathole Jun 10, 2025
b991093
feat: Added check for remote registry of referenced FeatureStore
ntkathole Jun 10, 2025
4e06343
Apply suggestions from code review
ntkathole Jun 11, 2025
e28a578
fix: Created GetFeastRestServiceName method
ntkathole Jun 11, 2025
63af9da
fix: Refactor createRestService to reuse setService
ntkathole Jun 11, 2025
dc176ba
fix: Handle service and port on grpc disable
ntkathole Jun 11, 2025
9785b9d
feat: Added isRegistryRestEnabled and isRegistryGrpcEnabled methods
ntkathole Jun 12, 2025
f231f0d
fix: Fixed rest server port
ntkathole Jun 12, 2025
68480ab
fix: Changes as per comments
ntkathole Jun 13, 2025
d73e524
fix: Handle tls mount for rest server
ntkathole Jun 13, 2025
6ace5ec
test: Added tests for field validations
ntkathole Jun 13, 2025
8c649c2
test: Added tests for svc probe, container port and registry validations
ntkathole Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Use isRegistryServer

Co-authored-by: Tommy Hughes IV <tchughesiv@gmail.com>
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
  • Loading branch information
@ntkathole @tchughesiv
ntkathole and tchughesiv committed Jun 9, 2025
commit ef5d3c4ac9d38709e5aefc63f133d2572c6caad6
10 changes: 4 additions & 6 deletions infra/feast-operator/internal/controller/services/services.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,9 +500,9 @@ func (feast *FeastServices) getContainerCommand(feastType FeastServiceType) []st
targetPort := deploySettings.TargetHttpPort
tls := feast.getTlsConfigs(feastType)

if feastType == RegistryFeastType {
registry := feast.Handler.FeatureStore.Spec.Services.Registry
if registry != nil && registry.Local != nil && registry.Local.Server != nil && registry.Local.Server.RestAPIEnabled {
if feastType == RegistryFeastType && feast.isRegistryServer() {
registry := feast.Handler.FeatureStore.Status.Applied.Services.Registry
if registry.Local.Server.RestAPIEnabled {
deploySettings.Args = append(deploySettings.Args, "--rest-api")
}
}
Expand Down Expand Up @@ -652,9 +652,7 @@ func (feast *FeastServices) getServerConfigs(feastType FeastServiceType) *feastd
return appliedServices.OnlineStore.Server
}
case RegistryFeastType:
if feast.isLocalRegistry() && appliedServices.Registry != nil &&
appliedServices.Registry.Local != nil &&
appliedServices.Registry.Local.Server != nil {
if feast.isRegistryServer() {
return &appliedServices.Registry.Local.Server.ServerConfigs
}
case UIFeastType:
Expand Down