feat: Allow to set registry server rest/grpc mode in operator#5364
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds capability in feast-operator to allow user to deploy registry serving in REST or gRPC or both mode.
New configuration fields:
GRPC: Toggle gRPC server (--grpc/--no-grpc)RestAPI: Toggle REST API server (--rest-api)When REST API is enabled:
Service hostnames:
Maintains backward compatibility with existing gRPC deployments.
Setting
restAPI: truewill deploy registry with :feast serve_registry --rest-apiAdditionally, also fixed the issue in f231f0d with rest port not used when grpc is disabled and only rest-api is enabled. Earlier it was using default grpc port instead of default rest port.