Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
  • Loading branch information
HaoXuAI committed Jun 1, 2025
commit 96e99b681ea12f74910e470bbc7439fcc3d0ff58
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/compute_engines/local/nodes.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ def execute(self, context: ExecutionContext) -> ArrowTableValue:
dedup_keys = context.column_info.join_keys
if dedup_keys:
sort_keys = [column_info.timestamp_column]
if column_info.created_timestamp_column:
if column_info.created_timestamp_column and column_info.created_timestamp_column in df.columns:
sort_keys.append(column_info.created_timestamp_column)

df = self.backend.drop_duplicates(
Expand Down
6 changes: 6 additions & 0 deletions sdk/python/feast/infra/offline_stores/ibis.py
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,12 @@ def pull_all_from_table_or_query_ibis(
)
)

if data_source.field_mapping:
for old_field_name in data_source.field_mapping:
table = table.rename(
{data_source.field_mapping[old_field_name]: old_field_name}
)

return IbisRetrievalJob(
table=table,
on_demand_feature_views=[],
Expand Down
1 change: 1 addition & 0 deletions sdk/python/feast/offline_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ def pull_all_from_table_or_query(self, command: dict):
data_source=data_source,
join_key_columns=command["join_key_columns"],
feature_name_columns=command["feature_name_columns"],
created_timestamp_column=command["created_timestamp_column"],
timestamp_field=command["timestamp_field"],
start_date=utils.make_tzaware(
datetime.fromisoformat(command["start_date"])
Expand Down