Skip to content

feat: Refactor materialization engine #5354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 17 commits into from
Jun 3, 2025
Merged

feat: Refactor materialization engine #5354

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1729394
move old materialization engines into compute engines
HaoXuAI May 14, 2025
467a5b9
move old materialization engines into compute engines
HaoXuAI May 14, 2025
277d39f
Merge branch 'master' into refactor-materialization-engine
HaoXuAI May 15, 2025
b1988d7
fix the test
HaoXuAI May 21, 2025
1a9548c
Merge branch 'master' into refactor-materialization-engine
HaoXuAI May 21, 2025
3b4912e
fix localcompute
HaoXuAI May 21, 2025
a667cf8
fix localcompute
HaoXuAI May 22, 2025
8a29f65
fix localcompute
HaoXuAI May 22, 2025
eab3d7f
fix localcompute
HaoXuAI May 24, 2025
58a7014
Merge branch 'master' into refactor-materialization-engine
HaoXuAI May 24, 2025
c5bdcb3
format
HaoXuAI May 24, 2025
217a931
fix test
HaoXuAI May 26, 2025
96e99b6
fix test
HaoXuAI Jun 1, 2025
bd77562
fix test
HaoXuAI Jun 1, 2025
55b1275
merge master
HaoXuAI Jun 1, 2025
65ecb46
fix lint
HaoXuAI Jun 1, 2025
24e3465
fix lint
HaoXuAI Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test 
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
  • Loading branch information
@HaoXuAI
HaoXuAI committed May 26, 2025
commit 217a93191917c803fd085f6dcfc4e77e4646cd3f
7 changes: 6 additions & 1 deletion sdk/python/feast/infra/offline_stores/dask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,12 @@ def evaluate_func():
if not join_key_columns:
df[DUMMY_ENTITY_ID] = DUMMY_ENTITY_VAL
columns_to_extract.add(DUMMY_ENTITY_ID)
return df[list(columns_to_extract)].persist()
# TODO: Decides if we want to field mapping for pull_latest_from_table_or_query
# This is default for other offline store.
df = df[list(columns_to_extract)]
df = _run_dask_field_mapping(df, data_source.field_mapping or {})
df.persist()
return df

# When materializing a single feature view, we don't need full feature names. On demand transforms aren't materialized
return DaskRetrievalJob(
Expand Down
Loading