Skip to content

feat: Enable users to use Entity Query as CTE during historical retrieval #5202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 6 commits into from
Apr 1, 2025
Merged

feat: Enable users to use Entity Query as CTE during historical retrieval #5202

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
41e3a5f
entity query as cte
blaketastic2 Mar 31, 2025
5b77838
formatting
blaketastic2 Mar 31, 2025
1dd7c08
backward compatible
blaketastic2 Mar 31, 2025
e0cf916
updated docs
blaketastic2 Mar 31, 2025
4376a7b
jinja2 template fix
blaketastic2 Apr 1, 2025
8892d5b
test data
blaketastic2 Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updated docs 
Signed-off-by: Blake <blaketastic2@gmail.com>
  • Loading branch information
@blaketastic2
blaketastic2 committed Mar 31, 2025
commit e0cf916bb165e480df6a6d93edf143c1a3382315
3 changes: 3 additions & 0 deletions docs/reference/offline-stores/postgres.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ offline_store:
sslkey_path: /path/to/client-key.pem
sslcert_path: /path/to/client-cert.pem
sslrootcert_path: /path/to/server-ca.pem
entity_select_mode: temp_table
online_store:
path: data/online_store.db
```
Expand All @@ -40,6 +41,8 @@ online_store:
Note that `sslmode`, `sslkey_path`, `sslcert_path`, and `sslrootcert_path` are optional parameters.
The full set of configuration options is available in [PostgreSQLOfflineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.offline_stores.contrib.postgres_offline_store.postgres.PostgreSQLOfflineStoreConfig).

Additionally, a new optional parameter `entity_select_mode` was added to tell how Postgres should load the entity data. By default(`temp_table`), a temporary table is created and the entity data frame or sql is loaded into that table. A new value of `embed_query` was added to allow directly loading the SQL query into a CTE, providing improved performance and skipping the need to CREATE and DROP the temporary table.

## Functionality Matrix

The set of functionality supported by offline stores is described in detail [here](overview.md#functionality).
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,9 +480,9 @@ def _get_entity_schema(
{% endfor %}
FROM
{% if entity_select_mode == EntitySelectMode.embed_query %}
{{ left_table_query_string }}
{% else %}
entity_query
{% else %}
{{ left_table_query_string }}
{% endif %}
),

Expand Down
Loading