Skip to content

feat: Enable users to use Entity Query as CTE during historical retrieval #5202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 6 commits into from
Apr 1, 2025
Merged

feat: Enable users to use Entity Query as CTE during historical retrieval #5202

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
41e3a5f
entity query as cte
blaketastic2 Mar 31, 2025
5b77838
formatting
blaketastic2 Mar 31, 2025
1dd7c08
backward compatible
blaketastic2 Mar 31, 2025
e0cf916
updated docs
blaketastic2 Mar 31, 2025
4376a7b
jinja2 template fix
blaketastic2 Apr 1, 2025
8892d5b
test data
blaketastic2 Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
jinja2 template fix 
Signed-off-by: Blake <blaketastic2@gmail.com>
  • Loading branch information
@blaketastic2
blaketastic2 committed Apr 1, 2025
commit 4376a7b960b5f381d25629d28b10089ef73dfc29
6 changes: 3 additions & 3 deletions sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ def build_point_in_time_query(
"featureviews": feature_view_query_contexts,
"full_feature_names": full_feature_names,
"final_output_feature_names": final_output_feature_names,
"entity_select_mode": entity_select_mode,
"entity_select_mode": entity_select_mode.value,
}

query = template.render(template_context)
Expand Down Expand Up @@ -456,7 +456,7 @@ def _get_entity_schema(

MULTIPLE_FEATURE_VIEW_POINT_IN_TIME_JOIN = """
WITH
{% if entity_select_mode == EntitySelectMode.embed_query %}
{% if entity_select_mode == "embed_query" %}
entity_query AS ({{ left_table_query_string }}),
{% endif %}
/*
Expand All @@ -479,7 +479,7 @@ def _get_entity_schema(
{% endif %}
{% endfor %}
FROM
{% if entity_select_mode == EntitySelectMode.embed_query %}
{% if entity_select_mode == "embed_query" %}
entity_query
{% else %}
{{ left_table_query_string }}
Expand Down
Loading
Loading