Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
e38a7c0
feat: Adding Docling RAG demo
franciscojavierarceo Mar 1, 2025
f9c7db4
updated demo
franciscojavierarceo Mar 2, 2025
4ba9fce
cleaned up notebook
franciscojavierarceo Mar 2, 2025
6c3ea35
adding chunk id
franciscojavierarceo Mar 2, 2025
410ded0
adding quickstart demo that is WIP and updating docling-demo to expor…
franciscojavierarceo Mar 2, 2025
8f0c663
adding current tentative exmaple repo
franciscojavierarceo Mar 2, 2025
f098674
adding current temporary work
franciscojavierarceo Mar 2, 2025
99dc5f3
updating to handle missed edge case
franciscojavierarceo Mar 3, 2025
29ca46f
linter
franciscojavierarceo Mar 3, 2025
3f23d25
updating demo script to rename things
franciscojavierarceo Mar 3, 2025
d366988
updated quickstart
franciscojavierarceo Mar 3, 2025
f917183
added comment
franciscojavierarceo Mar 3, 2025
e8b9e4a
checking in progress
franciscojavierarceo Mar 6, 2025
521abb5
updating with progress...found large bug
franciscojavierarceo Mar 6, 2025
731d6f1
almost have something working...very close
franciscojavierarceo Mar 7, 2025
f0d396d
have writes behaving, now need reads
franciscojavierarceo Mar 7, 2025
86b09c5
fixed writes and reads and unit test
franciscojavierarceo Mar 7, 2025
cbcbe70
got write test working (not explode though)
franciscojavierarceo Mar 7, 2025
48fba5f
checking in progress for now, still have some issues with vector retr…
franciscojavierarceo Mar 7, 2025
fef8666
okay think i have most things working
franciscojavierarceo Mar 8, 2025
8626762
unit tests are passing...still need to lint but checking in for tonight
franciscojavierarceo Mar 8, 2025
3cd0093
fixed unit test and linter...i believe
franciscojavierarceo Mar 9, 2025
ffac095
removing commenting and unnecessary code
franciscojavierarceo Mar 9, 2025
2e9d2d5
forgot to add file for unit tests
franciscojavierarceo Mar 9, 2025
94c60d6
skipping test for some
franciscojavierarceo Mar 9, 2025
fabd394
removing rag docling demo from this branch
franciscojavierarceo Mar 9, 2025
e545e4b
addding skip test back in for milvus
franciscojavierarceo Mar 9, 2025
548e0ce
removed print statement
franciscojavierarceo Mar 9, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removing commenting and unnecessary code
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
  • Loading branch information
franciscojavierarceo committed Mar 9, 2025
commit ffac095117f0e7677bb92f44229e7a522cd98979
9 changes: 0 additions & 9 deletions sdk/python/feast/infra/online_stores/sqlite.py
Original file line number Diff line number Diff line change
Expand Up @@ -176,14 +176,6 @@ def online_write_batch(
) # type: ignore
else:
val_bin = feast_value_type_to_python_type(val)
# print(
# f"entity_key_bin = {entity_key_bin} (type: {type(entity_key_bin)})\n"
# f"feature_name = {feature_name} (type: {type(feature_name)})\n"
# f"value = {val.SerializeToString()} (type: {type(val.SerializeToString())})\n"
# f"val_bin = {val_bin} (type: {type(val_bin)})\n"
# f"timestamp = {timestamp} (type: {type(timestamp)})\n"
# f"created_ts = {created_ts} (type: {type(created_ts)})\n"
# )
conn.execute(
f"""
INSERT INTO {table_name} (entity_key, feature_name, value, vector_value, event_ts, created_ts)
Expand Down Expand Up @@ -489,7 +481,6 @@ def retrieve_online_documents_v2(
raise ValueError("vector_len is not configured in the online store config")

table_name = _table_id(config.project, table)
# Currently this is the problem
vector_field = _get_vector_field(table)

if online_store.vector_enabled:
Expand Down
8 changes: 4 additions & 4 deletions sdk/python/tests/unit/online_store/test_online_retrieval.py
Original file line number Diff line number Diff line change
Expand Up @@ -854,10 +854,10 @@ def test_sqlite_hybrid_search() -> None:
res_df["title"].tolist() == ["Guardians of the Galaxy", "Sing", "Suicide Squad"]


# @pytest.mark.skipif(
# sys.version_info[0:2] != (3, 10),
# reason="Only works on Python 3.10",
# )
@pytest.mark.skipif(
sys.version_info[0:2] != (3, 10),
reason="Only works on Python 3.10",
)
def test_sqlite_get_online_documents_v2() -> None:
"""Test retrieving documents using v2 method with vector similarity search."""
n = 10
Expand Down