fixed writes and reads and unit test

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
feast-dev · franciscojavierarceo · Mar 9, 2025 · Mar 1, 2025 · Mar 2, 2025 · Mar 2, 2025
commit 86b09c5a97177a2dd33be7a3825b6c3a6b75519b
@@ -469,11 +469,13 @@ def _group_feature_refs(
     view_index = {view.projection.name_to_use(): view for view in all_feature_views}
 
     # on demand view to on demand view proto
-    on_demand_view_index = {
-        view.projection.name_to_use(): view
-        for view in all_on_demand_feature_views
-        if view.projection
-    }
+    on_demand_view_index: Dict[str, "OnDemandFeatureView"] = {}
+    for view in all_on_demand_feature_views:
+        if view.projection and not view.write_to_online_store:
+            on_demand_view_index[view.projection.name_to_use()] = view
+        elif view.projection and view.write_to_online_store:
+            # we insert the ODFV view to FVs for ones that are written to the online store
+            view_index[view.projection.name_to_use()] = view
 
     # view name to feature names
     views_features = defaultdict(set)

@@ -860,6 +860,9 @@ def test_stored_writes(self):
             assert driver_stats_fv.entities == [driver.name]
             assert driver_stats_fv.entity_columns == []
 
+            ODFV_STRING_CONSTANT = "guaranteed constant"
+            ODFV_OTHER_STRING_CONSTANT = "somethign else"
+
             @on_demand_feature_view(
                 entities=[driver],
                 sources=[
@@ -889,7 +892,7 @@ def python_stored_writes_feature_view(
                     "current_datetime": [datetime.now() for _ in inputs["conv_rate"]],
                     "counter": [c + 1 for c in inputs["counter"]],
                     "input_datetime": [d for d in inputs["input_datetime"]],
-                    "string_constant": ["guaranteed constant"],
+                    "string_constant": [ODFV_STRING_CONSTANT],
                 }
                 return output
 
@@ -980,7 +983,7 @@ def python_stored_writes_feature_view(
                     "conv_rate": 0.25,
                     "acc_rate": 0.50,
                     "input_datetime": current_datetime,
-                    "string_constant": "something else",
+                    "string_constant": ODFV_OTHER_STRING_CONSTANT,
                 }
             ]
             odfv_entity_rows_to_read = [
@@ -991,7 +994,7 @@ def python_stored_writes_feature_view(
                     "acc_rate": 0.50,
                     "counter": 0,
                     "input_datetime": current_datetime,
-                    "string_constant": "guaranteed constant",
+                    "string_constant": ODFV_STRING_CONSTANT,
                 }
             ]
             print("storing ODFV features")
@@ -1045,12 +1048,13 @@ def python_stored_writes_feature_view(
                     "string_constant",
                 ]
             )
-            # This should be 1 because we write the value and then we should not increment it
-            # query sqlite here to confirm value:
-            # self.store.config.online_store._conn.
-            assert online_odfv_python_response["counter"] == [0]
+            # This should be 1 because we write the value of 0 and during the write, the counter is incremented
+            assert online_odfv_python_response["counter"] == [1]
             assert online_odfv_python_response["string_constant"] == [
-                "gauranteed constant"
+                ODFV_STRING_CONSTANT
+            ]
+            assert online_odfv_python_response["string_constant"] != [
+                ODFV_OTHER_STRING_CONSTANT
             ]
 
     def test_stored_writes_with_explode(self):