Skip to content

feat: File persistence definition and implementation #4742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lokeshrangineni merged 13 commits into from
Nov 8, 2024
Merged

feat: File persistence definition and implementation #4742

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d64da1a
File persistence definition and implementation
dmartinol Nov 6, 2024
08b1011
removed optional and default markers
dmartinol Nov 6, 2024
9b07506
removed global cfg variable
dmartinol Nov 6, 2024
db3c5c5
reviewed ApplyDefaultsToStatus
dmartinol Nov 6, 2024
74c518c
extended checks in ApplyDefaultsToStatus
dmartinol Nov 6, 2024
da6a84f
removed var error
dmartinol Nov 6, 2024
bce16ca
added IsValidOfflineStoreFilePersistenceType to the API definitions
dmartinol Nov 7, 2024
15c595b
Merge branch 'feast-dev:master' into persistence_file
dmartinol Nov 7, 2024
251538d
moved IsValidOfflineStoreFilePersistenceType to services package and …
dmartinol Nov 7, 2024
ca09666
renamed isValidOfflineStoreFilePersistenceType to checkOfflineStoreFi…
dmartinol Nov 7, 2024
f1134ac
adding controller tests for ephemeral stores
dmartinol Nov 7, 2024
8677162
using slices package
dmartinol Nov 7, 2024
3b76db9
Merge branch 'feast-dev:master' into persistence_file
dmartinol Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions infra/feast-operator/api/v1alpha1/featurestore_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,16 +71,60 @@ type FeatureStoreServices struct {
// OfflineStore configures the deployed offline store service
type OfflineStore struct {
ServiceConfigs `json:",inline"`
// +optional
Comment thread
dmartinol marked this conversation as resolved.
Outdated
Persistence *OfflineStorePersistence `json:"persistence,omitempty"`
}

// OfflineStorePersistence configures the persistence settings for the offline store service
type OfflineStorePersistence struct {
// +optional
FilePersistence *OfflineStoreFilePersistence `json:"file,omitempty"`
}

// OfflineStorePersistence configures the file-based persistence for the offline store service
type OfflineStoreFilePersistence struct {
// +optional
// +default:value=dask
Comment thread
dmartinol marked this conversation as resolved.
Outdated
// +kubebuilder:validation:Enum=dask;duckdb
Type string `json:"type,omitempty"`
}
Comment thread
dmartinol marked this conversation as resolved.

// OnlineStore configures the deployed online store service
type OnlineStore struct {
ServiceConfigs `json:",inline"`
// +optional
Persistence *OnlineStorePersistence `json:"persistence,omitempty"`
}

// OnlineStorePersistence configures the persistence settings for the online store service
type OnlineStorePersistence struct {
// +optional
FilePersistence *OnlineStoreFilePersistence `json:"file,omitempty"`
}

// OnlineStoreFilePersistence configures the file-based persistence for the offline store service
type OnlineStoreFilePersistence struct {
// +optional
Path string `json:"path,omitempty"`
}

// LocalRegistryConfig configures the deployed registry service
type LocalRegistryConfig struct {
ServiceConfigs `json:",inline"`
// +optional
Persistence *RegistryPersistence `json:"persistence,omitempty"`
}

// RegistryPersistence configures the persistence settings for the registry service
type RegistryPersistence struct {
// +optional
FilePersistence *RegistryFilePersistence `json:"file,omitempty"`
}

// RegistryFilePersistence configures the file-based persistence for the registry service
type RegistryFilePersistence struct {
// +optional
Path string `json:"path,omitempty"`
}

// Registry configures the registry service. One selection is required. Local is the default setting.
Expand Down
120 changes: 120 additions & 0 deletions infra/feast-operator/api/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

80 changes: 80 additions & 0 deletions infra/feast-operator/config/crd/bases/feast.dev_featurestores.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,21 @@ spec:
description: PullPolicy describes a policy for if/when to
pull a container image
type: string
persistence:
description: OfflineStorePersistence configures the persistence
settings for the offline store service
properties:
file:
description: OfflineStorePersistence configures the file-based
persistence for the offline store service
properties:
type:
enum:
- dask
- duckdb
type: string
type: object
type: object
resources:
description: ResourceRequirements describes the compute resource
requirements.
Expand Down Expand Up @@ -361,6 +376,18 @@ spec:
description: PullPolicy describes a policy for if/when to
pull a container image
type: string
persistence:
description: OnlineStorePersistence configures the persistence
settings for the online store service
properties:
file:
description: OnlineStoreFilePersistence configures the
file-based persistence for the offline store service
properties:
path:
type: string
type: object
type: object
resources:
description: ResourceRequirements describes the compute resource
requirements.
Expand Down Expand Up @@ -546,6 +573,18 @@ spec:
description: PullPolicy describes a policy for if/when
to pull a container image
type: string
persistence:
description: RegistryPersistence configures the persistence
settings for the registry service
properties:
file:
description: RegistryFilePersistence configures the
file-based persistence for the registry service
properties:
path:
type: string
type: object
type: object
resources:
description: ResourceRequirements describes the compute
resource requirements.
Expand Down Expand Up @@ -780,6 +819,21 @@ spec:
description: PullPolicy describes a policy for if/when
to pull a container image
type: string
persistence:
description: OfflineStorePersistence configures the persistence
settings for the offline store service
properties:
file:
description: OfflineStorePersistence configures the
file-based persistence for the offline store service
properties:
type:
enum:
- dask
- duckdb
type: string
type: object
type: object
resources:
description: ResourceRequirements describes the compute
resource requirements.
Expand Down Expand Up @@ -962,6 +1016,19 @@ spec:
description: PullPolicy describes a policy for if/when
to pull a container image
type: string
persistence:
description: OnlineStorePersistence configures the persistence
settings for the online store service
properties:
file:
description: OnlineStoreFilePersistence configures
the file-based persistence for the offline store
service
properties:
path:
type: string
type: object
type: object
resources:
description: ResourceRequirements describes the compute
resource requirements.
Expand Down Expand Up @@ -1151,6 +1218,19 @@ spec:
description: PullPolicy describes a policy for if/when
to pull a container image
type: string
persistence:
description: RegistryPersistence configures the persistence
settings for the registry service
properties:
file:
description: RegistryFilePersistence configures
the file-based persistence for the registry
service
properties:
path:
type: string
type: object
type: object
resources:
description: ResourceRequirements describes the compute
resource requirements.
Expand Down
20 changes: 20 additions & 0 deletions infra/feast-operator/config/samples/v1alpha1_featurestore_ephemeral_persistence.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
apiVersion: feast.dev/v1alpha1
kind: FeatureStore
metadata:
name: sample-ephemeral-persistence
spec:
feastProject: my_project
services:
onlineStore:
persistence:
file:
path: /data/online_store.db
offlineStore:
persistence:
file:
type: dask
registry:
local:
persistence:
file:
path: /data/registry.db
Loading