Skip to content

feat: File persistence definition and implementation #4742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lokeshrangineni merged 13 commits into from
Nov 8, 2024
Merged

feat: File persistence definition and implementation #4742

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d64da1a
File persistence definition and implementation
dmartinol Nov 6, 2024
08b1011
removed optional and default markers
dmartinol Nov 6, 2024
9b07506
removed global cfg variable
dmartinol Nov 6, 2024
db3c5c5
reviewed ApplyDefaultsToStatus
dmartinol Nov 6, 2024
74c518c
extended checks in ApplyDefaultsToStatus
dmartinol Nov 6, 2024
da6a84f
removed var error
dmartinol Nov 6, 2024
bce16ca
added IsValidOfflineStoreFilePersistenceType to the API definitions
dmartinol Nov 7, 2024
15c595b
Merge branch 'feast-dev:master' into persistence_file
dmartinol Nov 7, 2024
251538d
moved IsValidOfflineStoreFilePersistenceType to services package and …
dmartinol Nov 7, 2024
ca09666
renamed isValidOfflineStoreFilePersistenceType to checkOfflineStoreFi…
dmartinol Nov 7, 2024
f1134ac
adding controller tests for ephemeral stores
dmartinol Nov 7, 2024
8677162
using slices package
dmartinol Nov 7, 2024
3b76db9
Merge branch 'feast-dev:master' into persistence_file
dmartinol Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed var error 
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
  • Loading branch information
@dmartinol
dmartinol committed Nov 6, 2024
commit da6a84f0895886846af83cb6c83539486867b5ce
1 change: 0 additions & 1 deletion infra/feast-operator/internal/controller/suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ var _ = BeforeSuite(func() {
fmt.Sprintf("1.29.0-%s-%s", runtime.GOOS, runtime.GOARCH)),
}

var err error
cfg, err := testEnv.Start()
Expect(err).NotTo(HaveOccurred())
Expect(cfg).NotTo(BeNil())
Expand Down