Skip to content

fix: Added Apply/Get/List/Delete methods to project_metadata to BaseRegistry #4441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EXPEbdodla wants to merge 6 commits into from
Closed

fix: Added Apply/Get/List/Delete methods to project_metadata to BaseRegistry #4441

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
785d7b2
feat: Added project metadata specific methods to base registry
Aug 23, 2024
9d8fdac
fix: Fixed lint issues
Aug 24, 2024
cc673e3
fix: Fixed lint issues in remote and registry files
Aug 24, 2024
6bddbf8
fix: Fixed test failures
Aug 24, 2024
54beea5
fix: Revert experimental optional field on ListProjectMetadataRequest…
Aug 24, 2024
23b279f
fix: Default to empty when project is None
Aug 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Fixed test failures 
Signed-off-by: Bhargav Dodla <bdodla@expediagroup.com>
  • Loading branch information
Bhargav Dodla committed Aug 24, 2024
commit 6bddbf8317854a1e9e3206f956d463e4d1439b39
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/registry/proto_registry_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ def list_validation_references(
def list_project_metadata(
registry_proto: RegistryProto, project: Optional[str]
) -> List[ProjectMetadata]:
if project is None:
if not project:
return [
ProjectMetadata.from_proto(project_metadata)
for project_metadata in registry_proto.project_metadata
Expand Down
8 changes: 7 additions & 1 deletion sdk/python/feast/infra/registry/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,7 +810,13 @@ def get_project_metadata(
registry_proto = self._get_registry_proto(
project=project, allow_cache=allow_cache
)
return proto_registry_utils.list_project_metadata(registry_proto, project)
project_metadata_proto = proto_registry_utils.get_project_metadata(
registry_proto, project
)
if project_metadata_proto is None:
return None
else:
return ProjectMetadata.from_proto(project_metadata_proto)

def delete_project_metadata(self, project: str, commit: bool = True):
self._prepare_registry_for_changes(project)
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/registry/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ def _list_on_demand_feature_views(

def _list_project_metadata(self, project: Optional[str]) -> List[ProjectMetadata]:
with self.engine.begin() as conn:
if project is None:
if not project:
stmt = select(feast_metadata)
else:
stmt = select(feast_metadata).where(
Expand Down
12 changes: 6 additions & 6 deletions sdk/python/tests/integration/registration/test_universal_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,12 +342,12 @@ def test_apply_entity_success(test_registry):

# Register Entity
test_registry.apply_entity(entity, project)
project_metadata = test_registry.list_project_metadata(project=project)
assert len(project_metadata) == 1
project_metadata = test_registry.list_project_metadata(project=None)
assert len(project_metadata) == 1
project_uuid = project_metadata[0].project_uuid
assert len(project_metadata[0].project_uuid) == 36
project_metadata_list = test_registry.list_project_metadata(project=project)
assert len(project_metadata_list) == 1
project_metadata_list = test_registry.list_project_metadata(project=None)
assert len(project_metadata_list) == 1
project_uuid = project_metadata_list[0].project_uuid
assert len(project_metadata_list[0].project_uuid) == 36
assert_project_uuid(project, project_uuid, test_registry)

entities = test_registry.list_entities(project, tags=entity.tags)
Expand Down