Skip to content

fix: Added Apply/Get/List/Delete methods to project_metadata to BaseRegistry #4441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EXPEbdodla wants to merge 6 commits into from
Closed

fix: Added Apply/Get/List/Delete methods to project_metadata to BaseRegistry #4441

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
785d7b2
feat: Added project metadata specific methods to base registry
Aug 23, 2024
9d8fdac
fix: Fixed lint issues
Aug 24, 2024
cc673e3
fix: Fixed lint issues in remote and registry files
Aug 24, 2024
6bddbf8
fix: Fixed test failures
Aug 24, 2024
54beea5
fix: Revert experimental optional field on ListProjectMetadataRequest…
Aug 24, 2024
23b279f
fix: Default to empty when project is None
Aug 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: Default to empty when project is None 
Signed-off-by: Bhargav Dodla <bdodla@expediagroup.com>
  • Loading branch information
Bhargav Dodla committed Aug 24, 2024
commit 23b279faa30e24f5d4dcc56854aa54b46943acc2
3 changes: 2 additions & 1 deletion sdk/python/feast/infra/registry/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,8 @@ def list_project_metadata(
self, project: Optional[str], allow_cache: bool = False
) -> List[ProjectMetadata]:
request = RegistryServer_pb2.ListProjectMetadataRequest(
project=project, allow_cache=allow_cache
project="" if project is None else project,
allow_cache=allow_cache,
)
response = self.stub.ListProjectMetadata(request)
return [ProjectMetadata.from_proto(pm) for pm in response.project_metadata]
Expand Down