Skip to content

feat: List all feature views #4256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 10 commits into from
Jun 8, 2024
Merged

feat: List all feature views #4256

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5f64011
feature: Adding type to base feature view
franciscojavierarceo Jun 4, 2024
7d4b807
fixed linter
franciscojavierarceo Jun 5, 2024
7d928a9
fixed type and meta
franciscojavierarceo Jun 5, 2024
dc98cd8
adding new listing
franciscojavierarceo Jun 5, 2024
86ec8b7
updated
franciscojavierarceo Jun 5, 2024
838377c
cleaning up changes
franciscojavierarceo Jun 6, 2024
c404579
reverting FV proto
franciscojavierarceo Jun 6, 2024
55c9879
doing simple way
franciscojavierarceo Jun 6, 2024
a9fd586
added a test
franciscojavierarceo Jun 6, 2024
dc754fd
updated to add warnings
franciscojavierarceo Jun 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
updated to add warnings 
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
  • Loading branch information
@franciscojavierarceo
franciscojavierarceo committed Jun 8, 2024
commit dc754fdb772edac14a9c57b7c118f1445b5b3f31
28 changes: 28 additions & 0 deletions sdk/python/feast/feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# limitations under the License.
import copy
import itertools
import logging
import os
import warnings
from collections import Counter, defaultdict
Expand Down Expand Up @@ -271,6 +272,10 @@ def list_feature_views(self, allow_cache: bool = False) -> List[FeatureView]:
Returns:
A list of feature views.
"""
logging.warning(
"list_feature_views will make breaking changes. Please use list_batch_feature_views instead. "
"list_feature_views will behave like list_all_feature_views in the future."
)
return self._list_feature_views(allow_cache)

def _list_all_feature_views(
Expand All @@ -288,6 +293,29 @@ def _list_feature_views(
self,
allow_cache: bool = False,
hide_dummy_entity: bool = True,
) -> List[FeatureView]:
logging.warning(
"_list_feature_views will make breaking changes. Please use _list_batch_feature_views instead. "
"_list_feature_views will behave like _list_all_feature_views in the future."
)
feature_views = []
for fv in self._registry.list_feature_views(
self.project, allow_cache=allow_cache
):
if (
hide_dummy_entity
and fv.entities
and fv.entities[0] == DUMMY_ENTITY_NAME
):
fv.entities = []
fv.entity_columns = []
feature_views.append(fv)
return feature_views

def _list_batch_feature_views(
self,
allow_cache: bool = False,
hide_dummy_entity: bool = True,
) -> List[FeatureView]:
feature_views = []
for fv in self._registry.list_feature_views(
Expand Down