Skip to content

feat: List all feature views #4256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 10 commits into from
Jun 8, 2024
+57 −0
Merged

feat: List all feature views #4256

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5f64011
feature: Adding type to base feature view
franciscojavierarceo Jun 4, 2024
7d4b807
fixed linter
franciscojavierarceo Jun 5, 2024
7d928a9
fixed type and meta
franciscojavierarceo Jun 5, 2024
dc98cd8
adding new listing
franciscojavierarceo Jun 5, 2024
86ec8b7
updated
franciscojavierarceo Jun 5, 2024
838377c
cleaning up changes
franciscojavierarceo Jun 6, 2024
c404579
reverting FV proto
franciscojavierarceo Jun 6, 2024
55c9879
doing simple way
franciscojavierarceo Jun 6, 2024
a9fd586
added a test
franciscojavierarceo Jun 6, 2024
dc754fd
updated to add warnings
franciscojavierarceo Jun 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed type and meta 
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
  • Loading branch information
@franciscojavierarceo
franciscojavierarceo committed Jun 5, 2024
commit 7d928a9a7a79e21380a12eddd3fe890e0997d121
4 changes: 0 additions & 4 deletions sdk/python/feast/feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,10 +366,6 @@ def to_proto_meta(self):
interval_proto.start_time.FromDatetime(interval[0])
interval_proto.end_time.FromDatetime(interval[1])
meta.materialization_intervals.append(interval_proto)
if self.feature_view_type:
meta.feature_view_type = self.feature_view_type
else:
meta.feature_view_type = FeatureViewType.BATCH
return meta

def get_ttl_duration(self):
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/stream_feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ def to_proto(self):
timestamp_field=self.timestamp_field,
aggregations=[agg.to_proto() for agg in self.aggregations],
mode=self.mode,
feature_view_type=self.feature_view_type,
feature_view_type=self.feature_view_type.value,
)

return StreamFeatureViewProto(spec=spec, meta=meta)
Expand Down