Skip to content

feat: Adding support for Native Python feature transformations for On Demand Feature Views #4045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 16 commits into from
Mar 28, 2024
Merged

feat: Adding support for Native Python feature transformations for On Demand Feature Views #4045

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
da3eba3
uploading current progress, not in a good state yet and have a lot of…
franciscojavierarceo Mar 26, 2024
f8fd949
bug fix
franciscojavierarceo Mar 26, 2024
bbc55de
uploading current progress...calling it a night
franciscojavierarceo Mar 26, 2024
0ac27be
uploading current progress
franciscojavierarceo Mar 27, 2024
b028f8f
updated types and refactored to adjust
franciscojavierarceo Mar 27, 2024
efe16d5
fixed types, substraits, and added tests
franciscojavierarceo Mar 27, 2024
74b77e6
fixed the casting issue
franciscojavierarceo Mar 27, 2024
16850e9
updated mode check
franciscojavierarceo Mar 27, 2024
aa90fc1
fixed lint and udf example...should be singleton
franciscojavierarceo Mar 28, 2024
26c1170
removed print statement
franciscojavierarceo Mar 28, 2024
231e2db
updated to fix integration test
franciscojavierarceo Mar 28, 2024
8fedca7
fixed unit test
franciscojavierarceo Mar 28, 2024
5eb583d
removed import
franciscojavierarceo Mar 28, 2024
b5b71e2
linter
franciscojavierarceo Mar 28, 2024
75a3023
removed print statement and OnlineResponseRow
franciscojavierarceo Mar 28, 2024
c5ecce6
fixed type validation
franciscojavierarceo Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed unit test 
Signed-off-by: Francisco Javier Arceo <franciscojavierarceo@users.noreply.github.com>
  • Loading branch information
@franciscojavierarceo
franciscojavierarceo committed Mar 28, 2024
commit 8fedca7edf651244ef98d9089c30863110a4ae02
99 changes: 48 additions & 51 deletions sdk/python/tests/unit/infra/test_inference_unit_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def test_view(features_df: pd.DataFrame) -> pd.DataFrame:
],
mode="python",
)
def python_native_test_view(input_dict: Dict[str, Any]) -> Dict[str, List[Any]]:
def python_native_test_view(input_dict: Dict[str, Any]) -> Dict[str, Any]:
output_dict: Dict[str, Any] = {
"output": input_dict["some_date"],
"object_output": str(input_dict["some_date"]),
Expand All @@ -100,59 +100,56 @@ def test_on_demand_features_invalid_type_inference():
schema=[Field(name="some_date", dtype=UnixTimestamp)],
)

# @on_demand_feature_view(
# sources=[date_request],
# schema=[
# Field(name="output", dtype=UnixTimestamp),
# Field(name="object_output", dtype=String),
# ],
# )
# def invalid_test_view(features_df: pd.DataFrame) -> pd.DataFrame:
# data = pd.DataFrame()
# data["output"] = features_df["some_date"]
# data["object_output"] = features_df["some_date"].astype(str)
# return data
#
# with pytest.raises(ValueError, match="Value with native type object"):
# invalid_test_view.infer_features()
#
# @on_demand_feature_view(
# schema=[
# Field(name="output", dtype=UnixTimestamp),
# Field(name="missing", dtype=String),
# ],
# sources=[date_request],
# )
# def view_with_missing_feature(features_df: pd.DataFrame) -> pd.DataFrame:
# data = pd.DataFrame()
# data["output"] = features_df["some_date"]
# return data
#
# with pytest.raises(SpecifiedFeaturesNotPresentError):
# view_with_missing_feature.infer_features()
#
# @on_demand_feature_view(
# sources=[date_request],
# schema=[
# Field(name="output", dtype=UnixTimestamp),
# Field(name="object_output", dtype=String),
# ],
# mode="pandas",
# )
# def python_native_test_invalid_pandas_view(
# input_dict: Dict[str, Any]
# ) -> Dict[str, Any]:
# output_dict: Dict[str, Any] = {
# "output": input_dict["some_date"],
# "object_output": str(input_dict["some_date"]),
# }
# return output_dict
#
# with pytest.raises(TypeError):
# python_native_test_invalid_pandas_view.infer_features()
@on_demand_feature_view(
sources=[date_request],
schema=[
Field(name="output", dtype=UnixTimestamp),
Field(name="object_output", dtype=String),
],
)
def invalid_test_view(features_df: pd.DataFrame) -> pd.DataFrame:
data = pd.DataFrame()
data["output"] = features_df["some_date"]
data["object_output"] = features_df["some_date"].astype(str)
return data

with pytest.raises(ValueError, match="Value with native type object"):
invalid_test_view.infer_features()

@on_demand_feature_view(
schema=[
Field(name="output", dtype=UnixTimestamp),
Field(name="missing", dtype=String),
],
sources=[date_request],
)
def view_with_missing_feature(features_df: pd.DataFrame) -> pd.DataFrame:
data = pd.DataFrame()
data["output"] = features_df["some_date"]
return data

with pytest.raises(SpecifiedFeaturesNotPresentError):
view_with_missing_feature.infer_features()

with pytest.raises(TypeError):
@on_demand_feature_view(
sources=[date_request],
schema=[
Field(name="output", dtype=UnixTimestamp),
Field(name="object_output", dtype=String),
],
mode="pandas",
)
def python_native_test_invalid_pandas_view(
input_dict: Dict[str, Any]
) -> Dict[str, Any]:
output_dict: Dict[str, Any] = {
"output": input_dict["some_date"],
"object_output": str(input_dict["some_date"]),
}
return output_dict

with pytest.raises(TypeError):
@on_demand_feature_view(
sources=[date_request],
schema=[
Expand Down