Skip to content

feat: Adding support for Native Python feature transformations for On Demand Feature Views #4045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 16 commits into from
Mar 28, 2024
Merged

feat: Adding support for Native Python feature transformations for On Demand Feature Views #4045

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
da3eba3
uploading current progress, not in a good state yet and have a lot of…
franciscojavierarceo Mar 26, 2024
f8fd949
bug fix
franciscojavierarceo Mar 26, 2024
bbc55de
uploading current progress...calling it a night
franciscojavierarceo Mar 26, 2024
0ac27be
uploading current progress
franciscojavierarceo Mar 27, 2024
b028f8f
updated types and refactored to adjust
franciscojavierarceo Mar 27, 2024
efe16d5
fixed types, substraits, and added tests
franciscojavierarceo Mar 27, 2024
74b77e6
fixed the casting issue
franciscojavierarceo Mar 27, 2024
16850e9
updated mode check
franciscojavierarceo Mar 27, 2024
aa90fc1
fixed lint and udf example...should be singleton
franciscojavierarceo Mar 28, 2024
26c1170
removed print statement
franciscojavierarceo Mar 28, 2024
231e2db
updated to fix integration test
franciscojavierarceo Mar 28, 2024
8fedca7
fixed unit test
franciscojavierarceo Mar 28, 2024
5eb583d
removed import
franciscojavierarceo Mar 28, 2024
b5b71e2
linter
franciscojavierarceo Mar 28, 2024
75a3023
removed print statement and OnlineResponseRow
franciscojavierarceo Mar 28, 2024
c5ecce6
fixed type validation
franciscojavierarceo Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed the casting issue 
Signed-off-by: Francisco Javier Arceo <franciscojavierarceo@users.noreply.github.com>
  • Loading branch information
@franciscojavierarceo
franciscojavierarceo committed Mar 27, 2024
commit 74b77e6de9ed2adcd983bc2ffcae62ebb994c8e7
30 changes: 8 additions & 22 deletions sdk/python/feast/on_demand_feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def __init__( # noqa: C901

if mode not in {"python", "pandas", "substrait"}:
raise Exception(
f"Unknown mode {mode}. OnDemandFeatureView only supports python or pandas UDFs and substraits."
f"Unknown mode {mode}. OnDemandFeatureView only supports python or pandas UDFs and substrait."
)
else:
self.mode = mode
Expand All @@ -145,32 +145,12 @@ def __init__( # noqa: C901
feature_transformation = PandasTransformation(udf, udf_string)
elif mode == "python":
feature_transformation = PythonTransformation(udf, udf_string)
elif mode == "substrait":
feature_transformation = SubstraitTransformation(
substrait_plan=udf_string
)
else:
pass
else:
raise Exception(
"OnDemandFeatureView needs to be initialized with either feature_transformation or udf arguments"
)
else:
# Note inspecting the return signature won't work with isinstance so this is the best alternative
if mode == "pandas":
feature_transformation = PandasTransformation(
feature_transformation.udf, feature_transformation.udf_string
)
elif mode == "python":
feature_transformation = PythonTransformation(
feature_transformation.udf, feature_transformation.udf_string
)
elif mode == "substrait":
feature_transformation = SubstraitTransformation(
substrait_plan=feature_transformation.substrait_plan
)
else:
pass

self.source_feature_view_projections: Dict[str, FeatureViewProjection] = {}
self.source_request_sources: Dict[str, RequestSource] = {}
Expand Down Expand Up @@ -705,6 +685,7 @@ def mainify(obj) -> None:
obj.__module__ = "__main__"

def decorator(user_function):

return_annotation = inspect.signature(user_function).return_annotation
if (
return_annotation
Expand Down Expand Up @@ -745,7 +726,12 @@ def decorator(user_function):
else:
udf_string = dill.source.getsource(user_function)
mainify(user_function)
transformation = PandasTransformation(user_function, udf_string)
if mode == "pandas":
transformation = PandasTransformation(user_function, udf_string)
elif mode == "python":
transformation = PythonTransformation(user_function, udf_string)
elif mode == "substrait":
pass

on_demand_feature_view_obj = OnDemandFeatureView(
name=user_function.__name__,
Expand Down
11 changes: 10 additions & 1 deletion sdk/python/tests/unit/test_on_demand_feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,16 @@ def test_python_native_transformation_mode():
with pytest.raises(TypeError):
assert (
on_demand_feature_view_python_native_err.feature_transformation
== PandasTransformation(python_native_udf, "python native udf source code")
== PythonTransformation(python_native_udf, "python native udf source code")
)

with pytest.raises(TypeError):
# This should fail
on_demand_feature_view_python_native_err.feature_transformation.transform(
{
"feature1": 0,
"feature2": 1,
}
)


Expand Down