Skip to content

feat: Apply cache to load proto registry for performance #3702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felixwang9817 merged 3 commits into from
Sep 12, 2023
+32 −1
Merged

feat: Apply cache to load proto registry for performance #3702

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65659fe
fix: Remove unused parameter
j1wonpark Jul 28, 2023
f762ea2
feat: Apply cache to load proto registry for performance
j1wonpark Jul 29, 2023
3ae34b7
fix: Fix update key when cache missed
j1wonpark Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Remove unused parameter 
Signed-off-by: Jiwon Park <bakjeeone@hotmail.com>
  • Loading branch information
@j1wonpark
j1wonpark committed Aug 29, 2023
commit 65659fef215ca2971bb191c2c94e999451a74cd2
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/registry/proto_registry_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def get_validation_reference(


def list_feature_services(
registry_proto: RegistryProto, project: str, allow_cache: bool = False
registry_proto: RegistryProto, project: str
) -> List[FeatureService]:
feature_services = []
for feature_service_proto in registry_proto.feature_services:
Expand Down