Skip to content

feat: Apply cache to load proto registry for performance #3702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felixwang9817 merged 3 commits into from
Sep 12, 2023
Merged

feat: Apply cache to load proto registry for performance #3702

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65659fe
fix: Remove unused parameter
j1wonpark Jul 28, 2023
f762ea2
feat: Apply cache to load proto registry for performance
j1wonpark Jul 29, 2023
3ae34b7
fix: Fix update key when cache missed
j1wonpark Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: Fix update key when cache missed 
Signed-off-by: phil-park <bakjeeone@hotmail.com>
  • Loading branch information
@j1wonpark
j1wonpark committed Aug 29, 2023
commit 3ae34b72769260fa852d31b846a01fd3a5e883b8
1 change: 1 addition & 0 deletions sdk/python/feast/infra/registry/proto_registry_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ def wrapper(registry_proto: RegistryProto, project: str):
return cache_value
else:
cache_value = func(registry_proto, project)
Comment on lines +39 to +40
Copy link
Copy Markdown
Member

@achals achals Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to update cache_key here as well?

Copy link
Copy Markdown
Contributor Author

@j1wonpark j1wonpark Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@achals I'm sorry, you're right. I added commit b8a373f

cache_key = key
return cache_value

return wrapper
Expand Down