Skip to content

feat: Implement gRPC server to ingest streaming features #3687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adchia merged 15 commits into from
Sep 7, 2023
Merged

feat: Implement gRPC server to ingest streaming features #3687

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b235d1a
Implemented gRPC server for ingesting streaming features.
Jul 15, 2023
1b4bf8d
[lint-python]
Jul 15, 2023
809b9eb
Fix unmatched gRPC field issue.
Jul 17, 2023
5ea58d1
Make max_workers parameter configurable.
Jul 27, 2023
9766c53
[lint-python]
Jul 27, 2023
b92b838
Refactor gRPC server to have similar logic with HTTP server
Aug 7, 2023
caed020
Refactor CLI.
Aug 7, 2023
cd537d9
Type parameter.
Aug 7, 2023
d73c3d7
Upgrade 3.8 requirements.
Aug 7, 2023
a5000d8
Configure health check service and update CI dependencies
Aug 7, 2023
be0010d
Downgrade flake8 version to prevent E721 checks.
Aug 17, 2023
5f73e77
lint
adchia Sep 5, 2023
392768a
fix grpcio pin
adchia Sep 5, 2023
0c75491
fix lint
adchia Sep 5, 2023
068de80
Fix linter
adchia Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make max_workers parameter configurable. 
Signed-off-by: mehmettokgoz <mehmet.tokgoz@hazelcast.com>
Signed-off-by: Danny C <d.chiao@gmail.com>
  • Loading branch information
@adchia
Mehmet Tokgöz authored and adchia committed Sep 5, 2023
commit 5ea58d12ea1beaa8d08e18f9ab42b9e5af11a85a
18 changes: 13 additions & 5 deletions sdk/python/feast/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,26 +701,34 @@ def serve_command(
type=click.STRING,
default="localhost:50051",
show_default=True,
help="Specify an address for the server",
help="Address of the gRPC server",
)
@click.option(
"--stream_feature_view",
"-sfv",
type=click.STRING,
show_default=False,
help="Specify the stream feature view to update",
help="Stream feature view to push streaming features",
)
@click.option(
"--push_mode",
"-to",
type=click.STRING,
default="online",
show_default=False,
help="Specify the stream feature view to update",
help="Push mode for the streaming data",
)
@click.option(
"--max_workers",
"-w",
type=click.INT,
default=10,
show_default=False,
help="The maximum number of threads that can be used to execute the gRPC calls",
)
@click.pass_context
def listen_command(
ctx: click.Context, address: str, stream_feature_view: str, push_mode: str
ctx: click.Context, address: str, stream_feature_view: str, push_mode: str, max_workers: int
):
repo = ctx.obj["CHDIR"]
fs_yaml_file = ctx.obj["FS_YAML_FILE"]
Expand All @@ -733,7 +741,7 @@ def listen_command(
to = PushMode.OFFLINE
else:
to = PushMode.ONLINE_AND_OFFLINE
server = GetGrpcServer(store, address, stream_feature_view, to)
server = GetGrpcServer(store, address, stream_feature_view, to, max_workers)
server.start()


Expand Down
8 changes: 4 additions & 4 deletions sdk/python/feast/infra/contrib/grpc_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ def GrpcIngestFeature(self, request, context):


class GrpcIngestFeatureServer:
def __init__(self, address, fs: FeatureStore, sfv_name, to):
def __init__(self, address, fs: FeatureStore, sfv_name, to, max_workers):
Comment thread
adchia marked this conversation as resolved.
Outdated
Comment thread
adchia marked this conversation as resolved.
Outdated
self.address = address
self.fs = fs
self.sfv = sfv_name
self.server = grpc.server(futures.ThreadPoolExecutor(max_workers=10))
self.server = grpc.server(futures.ThreadPoolExecutor(max_workers=max_workers))
add_GrpcIngestFeatureServiceServicer_to_server(
Comment thread
adchia marked this conversation as resolved.
Outdated
GrpcIngestFeatureService(self.fs, self.sfv, to), self.server
)
Expand All @@ -51,5 +51,5 @@ def start(self):
self.server.wait_for_termination()


def GetGrpcServer(fs: FeatureStore, address: str, sfv: str, to: PushMode):
return GrpcIngestFeatureServer(address, fs, sfv, to)
def GetGrpcServer(fs: FeatureStore, address: str, sfv: str, to: PushMode, max_workers):
Comment thread
adchia marked this conversation as resolved.
Outdated
return GrpcIngestFeatureServer(address, fs, sfv, to, max_workers)