Skip to content

feat: Implement gRPC server to ingest streaming features #3687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adchia merged 15 commits into from
Sep 7, 2023
Merged

feat: Implement gRPC server to ingest streaming features #3687

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b235d1a
Implemented gRPC server for ingesting streaming features.
Jul 15, 2023
1b4bf8d
[lint-python]
Jul 15, 2023
809b9eb
Fix unmatched gRPC field issue.
Jul 17, 2023
5ea58d1
Make max_workers parameter configurable.
Jul 27, 2023
9766c53
[lint-python]
Jul 27, 2023
b92b838
Refactor gRPC server to have similar logic with HTTP server
Aug 7, 2023
caed020
Refactor CLI.
Aug 7, 2023
cd537d9
Type parameter.
Aug 7, 2023
d73c3d7
Upgrade 3.8 requirements.
Aug 7, 2023
a5000d8
Configure health check service and update CI dependencies
Aug 7, 2023
be0010d
Downgrade flake8 version to prevent E721 checks.
Aug 17, 2023
5f73e77
lint
adchia Sep 5, 2023
392768a
fix grpcio pin
adchia Sep 5, 2023
0c75491
fix lint
adchia Sep 5, 2023
068de80
Fix linter
adchia Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[lint-python] 
Signed-off-by: mehmettokgoz <mehmet.tokgoz@hazelcast.com>
Signed-off-by: Danny C <d.chiao@gmail.com>
  • Loading branch information
@adchia
mehmettokgoz authored and adchia committed Sep 5, 2023
commit 1b4bf8d169a52928d45a88a136f76da7ae4719c7
5 changes: 1 addition & 4 deletions sdk/python/feast/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,10 +720,7 @@ def serve_command(
)
@click.pass_context
def listen_command(
ctx: click.Context,
address: str,
stream_feature_view: str,
push_mode: str
ctx: click.Context, address: str, stream_feature_view: str, push_mode: str
):
repo = ctx.obj["CHDIR"]
fs_yaml_file = ctx.obj["FS_YAML_FILE"]
Expand Down
16 changes: 11 additions & 5 deletions sdk/python/feast/infra/contrib/grpc_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
from feast.protos.feast.serving.GrpcServer_pb2 import GrpcIngestFeatureResponse
from feast.protos.feast.serving.GrpcServer_pb2_grpc import GrpcIngestFeatureServiceServicer, \
add_GrpcIngestFeatureServiceServicer_to_server
from concurrent import futures
Comment thread
adchia marked this conversation as resolved.

import grpc
import pandas as pd
from feast.feature_store import FeatureStore

from feast.data_source import PushMode
from feast.feature_store import FeatureStore
from feast.protos.feast.serving.GrpcServer_pb2 import GrpcIngestFeatureResponse
from feast.protos.feast.serving.GrpcServer_pb2_grpc import (
GrpcIngestFeatureServiceServicer,
add_GrpcIngestFeatureServiceServicer_to_server,
)


class GrpcIngestFeatureService(GrpcIngestFeatureServiceServicer):
Expand Down Expand Up @@ -37,7 +41,9 @@ def __init__(self, address, fs: FeatureStore, sfv_name, to):
self.fs = fs
self.sfv = sfv_name
self.server = grpc.server(futures.ThreadPoolExecutor(max_workers=10))
Comment thread
adchia marked this conversation as resolved.
Outdated
add_GrpcIngestFeatureServiceServicer_to_server(GrpcIngestFeatureService(self.fs, self.sfv, to), self.server)
add_GrpcIngestFeatureServiceServicer_to_server(
Comment thread
adchia marked this conversation as resolved.
Outdated
GrpcIngestFeatureService(self.fs, self.sfv, to), self.server
)
self.server.add_insecure_port(self.address)

def start(self):
Expand Down