Skip to content

fix: Fix Java helm charts to work with refactored logic. Fix FTS image #3105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 9 commits into from
Aug 19, 2022
Merged

fix: Fix Java helm charts to work with refactored logic. Fix FTS image #3105

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4ec88a9
fix: Fix Java helm charts to work with refactored logic. Also include…
adchia Aug 18, 2022
47a7a96
fix helm docs and accidental issues
adchia Aug 18, 2022
7c17d37
fix
adchia Aug 18, 2022
9f0eedb
fix
adchia Aug 18, 2022
50eb0e7
fix
adchia Aug 18, 2022
59135fb
fix issues with templates
adchia Aug 18, 2022
3be6127
fix issues with templates
adchia Aug 18, 2022
845ca0a
fix serving README
adchia Aug 18, 2022
9224b06
fix go
adchia Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix serving README 
Signed-off-by: Danny Chiao <danny@tecton.ai>
  • Loading branch information
@adchia
adchia committed Aug 18, 2022
commit 845ca0a2e510c49bada20dffad934750b51e4642
14 changes: 9 additions & 5 deletions java/serving/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,18 @@
### Overview
This guide is targeted at developers looking to contribute to Feast Serving:
- [Building and running Feast Serving locally](#building-and-running-feast-serving-locally)
- [Unit / Integration Tests](#unit-/-integration-tests)
- [Developing against Feast Helm charts](#developing-against-feast-helm-charts)

### Pre-requisites:
### Building and running Feast Serving locally:

#### Pre-requisites

- [Maven](https://maven.apache.org/install.html) build tool version 3.6.x
- A Feast feature repo (e.g. https://github.com/feast-dev/feast-demo)
- A running Store instance e.g. local Redis instance with `redis-server`

### Building and running Feast Serving locally:
#### Steps
From the Feast GitHub root, run:

1. `mvn -f java/pom.xml install -Dmaven.test.skip=true`
Expand Down Expand Up @@ -46,7 +50,7 @@ From the Feast GitHub root, run:
```
5. Now you have a Feast Serving gRPC service running on port 6566 locally!

### Running test queries
#### Running test queries
If you have [grpc_cli](https://github.com/grpc/grpc/blob/master/doc/command_line_tool.md) installed, you can check that Feast Serving is running
```
grpc_cli ls localhost:6566
Expand Down Expand Up @@ -116,7 +120,7 @@ results {
Rpc succeeded with OK status
```

### Debugging Feast Serving
#### Debugging Feast Serving
You can debug this like any other Java executable. Swap the java command above with:
```
java \
Expand All @@ -140,6 +144,6 @@ mvn verify -pl serving --also-make
mvn -Dmaven.failsafe.debug verify -pl serving --also-make
```

### Developing against Feast helm charts
### Developing against Feast Helm charts
Look at [java-demo](../../examples/java-demo) for steps on how to update the helm chart or java logic and test their
interactions.