Skip to content

fix: Fix Java helm charts to work with refactored logic. Fix FTS image #3105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 9 commits into from
Aug 19, 2022
Merged

fix: Fix Java helm charts to work with refactored logic. Fix FTS image #3105

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4ec88a9
fix: Fix Java helm charts to work with refactored logic. Also include…
adchia Aug 18, 2022
47a7a96
fix helm docs and accidental issues
adchia Aug 18, 2022
7c17d37
fix
adchia Aug 18, 2022
9f0eedb
fix
adchia Aug 18, 2022
50eb0e7
fix
adchia Aug 18, 2022
59135fb
fix issues with templates
adchia Aug 18, 2022
3be6127
fix issues with templates
adchia Aug 18, 2022
845ca0a
fix serving README
adchia Aug 18, 2022
9224b06
fix go
adchia Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix issues with templates 
Signed-off-by: Danny Chiao <danny@tecton.ai>
  • Loading branch information
@adchia
adchia committed Aug 18, 2022
commit 59135fb50ea653f4037141e56efd13867d9e545e
4 changes: 3 additions & 1 deletion infra/charts/feast-feature-server/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ COPY feature_store.yaml /feature_store.yaml
Furthermore, if you wish to use the Go feature server, then you must install the Apache Arrow C++ libraries, and your `feature_store.yaml` should include `go_feature_server: True`.
For more details, see the [docs](https://docs.feast.dev/reference/feature-servers/go-feature-server).
The docker image might look like:
```
```
FROM python:3.8

RUN apt update && \
apt install -y jq
RUN pip install pip --upgrade
Expand All @@ -38,6 +39,7 @@ Furthermore, if you wish to use the Go feature server, then you must install the
RUN apt install -y -V ./apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb
RUN apt update
RUN apt -y install libarrow-dev

COPY feature_store.yaml /feature_store.yaml
```

Expand Down
4 changes: 3 additions & 1 deletion infra/charts/feast-feature-server/README.md.gotmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ COPY feature_store.yaml /feature_store.yaml
Furthermore, if you wish to use the Go feature server, then you must install the Apache Arrow C++ libraries, and your `feature_store.yaml` should include `go_feature_server: True`.
For more details, see the [docs](https://docs.feast.dev/reference/feature-servers/go-feature-server).
The docker image might look like:
```
```
FROM python:3.8

RUN apt update && \
apt install -y jq
RUN pip install pip --upgrade
Expand All @@ -38,6 +39,7 @@ Furthermore, if you wish to use the Go feature server, then you must install the
RUN apt install -y -V ./apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb
RUN apt update
RUN apt -y install libarrow-dev

COPY feature_store.yaml /feature_store.yaml
```

Expand Down
2 changes: 0 additions & 2 deletions infra/charts/feast/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# Feast Helm Charts

> :warning: **Disclaimer**: Since Feast 0.10 our vision is to manage all infrastructure for feature store from one place - Feast SDK. But while this new paradigm is still in development, we are planning to support the installation of some Feast components (like Java feature server) through Helm chart presented in this repository. However, we do not expect helm chart to become a long-term solution for deploying Feast components to production, and some frictions still might exist. For example, you will need to manually sync some configurations from [feature_store.yaml](https://docs.feast.dev/reference/feature-repository/feature-store-yaml) into the chart context (like path to the registry file or project name).

This repo contains Helm charts for Feast components that are being installed on Kubernetes:
* Feast (root chart): The complete Helm chart containing all Feast components and dependencies. Most users will use this chart, but can selectively enable/disable subcharts using the values.yaml file.
* [Feature Server](charts/feature-server): High performant JVM-based implementation of feature server.
Expand Down
2 changes: 0 additions & 2 deletions infra/charts/feast/README.md.gotmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# Feast Helm Charts

> :warning: **Disclaimer**: Since Feast 0.10 our vision is to manage all infrastructure for feature store from one place - Feast SDK. But while this new paradigm is still in development, we are planning to support the installation of some Feast components (like Java feature server) through Helm chart presented in this repository. However, we do not expect helm chart to become a long-term solution for deploying Feast components to production, and some frictions still might exist. For example, you will need to manually sync some configurations from [feature_store.yaml](https://docs.feast.dev/reference/feature-repository/feature-store-yaml) into the chart context (like path to the registry file or project name).

This repo contains Helm charts for Feast components that are being installed on Kubernetes:
* Feast (root chart): The complete Helm chart containing all Feast components and dependencies. Most users will use this chart, but can selectively enable/disable subcharts using the values.yaml file.
* [Feature Server](charts/feature-server): High performant JVM-based implementation of feature server.
Expand Down