Skip to content

ci: Fix build and ensure that building the java feature server is part of PR CI - #3052

Merged
adchia merged 1 commit into
feast-dev:masterfrom
adchia:fixBuild
Aug 9, 2022
Merged

ci: Fix build and ensure that building the java feature server is part of PR CI#3052
adchia merged 1 commit into
feast-dev:masterfrom
adchia:fixBuild

Conversation

@adchia

@adchia adchia commented Aug 9, 2022

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

…t of the java_pr workflow

Signed-off-by: Danny Chiao <danny@tecton.ai>

@achals achals left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter

codecov-commenter commented Aug 9, 2022

Copy link
Copy Markdown

Codecov Report

Merging #3052 (71e8e04) into master (2c30f88) will decrease coverage by 8.97%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3052      +/-   ##
==========================================
- Coverage   67.59%   58.61%   -8.98%     
==========================================
  Files         168      198      +30     
  Lines       14712    16344    +1632     
==========================================
- Hits         9944     9580     -364     
- Misses       4768     6764    +1996     
Flag Coverage Δ
integrationtests ?
unittests 58.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sts/integration/registration/test_universal_cli.py 20.20% <0.00%> (-79.80%) ⬇️
...ts/integration/offline_store/test_offline_write.py 26.08% <0.00%> (-73.92%) ⬇️
...fline_store/test_universal_historical_retrieval.py 28.75% <0.00%> (-71.25%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 29.50% <0.00%> (-70.50%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 27.55% <0.00%> (-69.30%) ⬇️
...s/integration/registration/test_universal_types.py 32.25% <0.00%> (-67.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 28.39% <0.00%> (-66.67%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 33.87% <0.00%> (-66.13%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
...n/tests/integration/registration/test_inference.py 35.71% <0.00%> (-64.29%) ⬇️
... and 149 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adchia
adchia merged commit bc8b3a3 into feast-dev:master Aug 9, 2022
@adchia
adchia deleted the fixBuild branch August 9, 2022 23:06
@adchia
adchia restored the fixBuild branch August 9, 2022 23:15
adchia added a commit that referenced this pull request Aug 10, 2022
…t of PR CI (#3052)

ci: Fix build and ensure that building the java feature server is part of the java_pr workflow

Signed-off-by: Danny Chiao <danny@tecton.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants