Skip to content

ci: Fix build and ensure that building the java feature server is part of PR CI #3052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adchia merged 1 commit into from
Aug 9, 2022
Merged

ci: Fix build and ensure that building the java feature server is part of PR CI #3052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/java_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,26 @@ jobs:
name: java-coverage-report
path: ${{ github.workspace }}/docs/coverage/java/target/site/jacoco-aggregate/

build-docker-image-java:
runs-on: ubuntu-latest
strategy:
matrix:
component: [ feature-server-java ]
env:
REGISTRY: gcr.io/kf-feast
steps:
- uses: actions/checkout@v2
with:
submodules: 'true'
- run: gcloud auth configure-docker --quiet
- name: Get m2 cache
run: |
infra/scripts/download-maven-cache.sh \
--archive-uri ${MAVEN_CACHE} \
--output-dir .
- name: Build image
run: make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA}

integration-test:
# all jobs MUST have this if check for 'ok-to-test' or 'approved' for security purposes.
if:
Expand Down
2 changes: 1 addition & 1 deletion java/infra/docker/feature-server/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ COPY java/pom.xml .
COPY java/datatypes/pom.xml datatypes/pom.xml
COPY java/serving/pom.xml serving/pom.xml
COPY java/serving-client/pom.xml serving-client/pom.xml
COPY java/docs/coverage/pom.xml docs/coverage/pom.xml
COPY java/coverage/pom.xml coverage/pom.xml

# Setting Maven repository .m2 directory relative to /build folder gives the
# user to optionally use cached repository when building the image by copying
Expand Down