Skip to content

fix: Refactor testing and sort out unit and integration tests #2975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 30 commits into from
Jul 29, 2022
Merged

fix: Refactor testing and sort out unit and integration tests #2975

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
c16d9ad
Refactor go feature server
kevjumba Jul 27, 2022
562dcb4
Fix lint
kevjumba Jul 27, 2022
d9ab146
Fix e2e tests
kevjumba Jul 27, 2022
209d15b
Fix
kevjumba Jul 27, 2022
af96f09
Verify tests
kevjumba Jul 27, 2022
374d0af
Fix lint
kevjumba Jul 27, 2022
826524b
Address review
kevjumba Jul 27, 2022
11a059c
Fix
kevjumba Jul 27, 2022
56c04f0
Address review
kevjumba Jul 27, 2022
7b6ee9f
Fix
kevjumba Jul 27, 2022
4835499
Fix lint
kevjumba Jul 28, 2022
44164f8
address review
kevjumba Jul 28, 2022
375d65d
Fix
kevjumba Jul 28, 2022
0d49d71
Fix
kevjumba Jul 28, 2022
ef2465f
Fix lint
kevjumba Jul 28, 2022
5b2edb7
Fix lint
kevjumba Jul 28, 2022
5397529
Fix
kevjumba Jul 28, 2022
1e633c0
Fix
kevjumba Jul 28, 2022
513f95c
Fix lint
kevjumba Jul 28, 2022
eaae4f2
Fix
kevjumba Jul 28, 2022
5e8734e
Refactor
kevjumba Jul 28, 2022
da8e4fa
Fix
kevjumba Jul 28, 2022
43b3900
Fx lit
kevjumba Jul 28, 2022
d5aad96
Fix lint
kevjumba Jul 28, 2022
1cb34ed
update fix
kevjumba Jul 28, 2022
aa6fa79
Fix
kevjumba Jul 28, 2022
27ef453
Revert
kevjumba Jul 28, 2022
1b303ac
Fix
kevjumba Jul 28, 2022
9067a45
fix
kevjumba Jul 29, 2022
96b7efb
Fix lint
kevjumba Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix 
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
@kevjumba
kevjumba committed Jul 29, 2022
commit 7b6ee9ff58380318ee8a3548d33777b019a9cfea
4 changes: 2 additions & 2 deletions sdk/python/tests/utils/feature_test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from feast.protos.feast.serving.ServingService_pb2 import FieldStatus


def get_latest_rows(df, join_key, entity_values):
def get_latest_rows(df: pd.DataFrame, join_key: str, entity_values: List[str]) -> pd.DataFrame:
"""
Return latest rows in a dataframe based on join key and entity values.

Expand All @@ -38,7 +38,7 @@ def generate_expected_logs(
features: List[str],
join_keys: List[str],
timestamp_column: str,
):
) -> pd.DataFrame:
"""
Given dataframe and feature view, generate the expected logging dataframes that would be otherwise generated by our logging infrastructure.
Args:
Expand Down