Skip to content

fix: Refactor testing and sort out unit and integration tests #2975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 30 commits into from
Jul 29, 2022
Merged

fix: Refactor testing and sort out unit and integration tests #2975

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
c16d9ad
Refactor go feature server
kevjumba Jul 27, 2022
562dcb4
Fix lint
kevjumba Jul 27, 2022
d9ab146
Fix e2e tests
kevjumba Jul 27, 2022
209d15b
Fix
kevjumba Jul 27, 2022
af96f09
Verify tests
kevjumba Jul 27, 2022
374d0af
Fix lint
kevjumba Jul 27, 2022
826524b
Address review
kevjumba Jul 27, 2022
11a059c
Fix
kevjumba Jul 27, 2022
56c04f0
Address review
kevjumba Jul 27, 2022
7b6ee9f
Fix
kevjumba Jul 27, 2022
4835499
Fix lint
kevjumba Jul 28, 2022
44164f8
address review
kevjumba Jul 28, 2022
375d65d
Fix
kevjumba Jul 28, 2022
0d49d71
Fix
kevjumba Jul 28, 2022
ef2465f
Fix lint
kevjumba Jul 28, 2022
5b2edb7
Fix lint
kevjumba Jul 28, 2022
5397529
Fix
kevjumba Jul 28, 2022
1e633c0
Fix
kevjumba Jul 28, 2022
513f95c
Fix lint
kevjumba Jul 28, 2022
eaae4f2
Fix
kevjumba Jul 28, 2022
5e8734e
Refactor
kevjumba Jul 28, 2022
da8e4fa
Fix
kevjumba Jul 28, 2022
43b3900
Fx lit
kevjumba Jul 28, 2022
d5aad96
Fix lint
kevjumba Jul 28, 2022
1cb34ed
update fix
kevjumba Jul 28, 2022
aa6fa79
Fix
kevjumba Jul 28, 2022
27ef453
Revert
kevjumba Jul 28, 2022
1b303ac
Fix
kevjumba Jul 28, 2022
9067a45
fix
kevjumba Jul 29, 2022
96b7efb
Fix lint
kevjumba Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fx lit 
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
@kevjumba
kevjumba committed Jul 29, 2022
commit 43b3900340f98ac891f663dcdda90967d88c9983
2 changes: 1 addition & 1 deletion sdk/python/tests/integration/online_store/test_universal_online.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
create_driver_hourly_stats_feature_view,
driver_feature_view,
)
from tests.utils.data_source_creator import prep_file_source
from tests.utils.data_source_test_creator import prep_file_source


@pytest.mark.integration
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/integration/registration/test_feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
from feast.infra.online_stores.sqlite import SqliteOnlineStoreConfig
from feast.repo_config import RepoConfig
from feast.types import Array, Bytes, Float64, Int64, String
from tests.utils.data_source_creator import (
from tests.utils.data_source_test_creator import (
prep_file_source,
simple_bq_source_using_query_arg,
simple_bq_source_using_table_arg,
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/integration/registration/test_inference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from feast import RepoConfig
from feast.errors import RegistryInferenceFailure
from feast.inference import update_data_sources_with_inferred_event_timestamp_col
from tests.utils.data_source_creator import (
from tests.utils.data_source_test_creator import (
prep_file_source,
simple_bq_source_using_query_arg,
simple_bq_source_using_table_arg,
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/unit/diff/test_registry_diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
)
from feast.entity import Entity
from feast.feature_view import FeatureView
from tests.utils.data_source_utils import prep_file_source
from tests.utils.data_source_test_creator import prep_file_source


def test_tag_objects_for_keep_delete_update_add(simple_dataset_1):
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/unit/infra/test_inference_unit_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from feast.on_demand_feature_view import on_demand_feature_view
from feast.repo_config import RepoConfig
from feast.types import Float32, Float64, Int64, String, UnixTimestamp, ValueType
from tests.utils.data_source_creator import prep_file_source
from tests.utils.data_source_test_creator import prep_file_source


def test_infer_datasource_names_file():
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/unit/local_feast_tests/test_local_feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from feast.infra.online_stores.sqlite import SqliteOnlineStoreConfig
from feast.repo_config import RepoConfig
from feast.types import Array, Bytes, Int64, String
from tests.utils.data_source_utils import prep_file_source
from tests.utils.data_source_test_creator import prep_file_source


@pytest.mark.parametrize(
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/unit/local_feast_tests/test_stream_feature_view_apply.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from feast.stream_feature_view import stream_feature_view
from feast.types import Float32
from tests.utils.cli_helper_functions import CliRunner, get_example_repo
from tests.utils.data_source_creator import prep_file_source
from tests.utils.data_source_test_creator import prep_file_source


def test_apply_stream_feature_view(simple_dataset_1) -> None:
Expand Down
0 ...python/tests/utils/data_source_creator.py → ...n/tests/utils/data_source_test_creator.py
View file
Open in desktop
File renamed without changes.