Skip to content

ci: Disable Go for Python 3.10 release#2858

Merged
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
felixwang9817:disable_go_py310
Jun 24, 2022
Merged

ci: Disable Go for Python 3.10 release#2858
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
felixwang9817:disable_go_py310

Conversation

@felixwang9817
Copy link
Copy Markdown
Collaborator

@felixwang9817 felixwang9817 commented Jun 24, 2022

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@felixwang9817
Disable Go for Python 3.10 release
6a84951 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 24, 2022 •
edited
Loading

Codecov Report

Merging #2858 (6a84951) into master (e50019c) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2858      +/-   ##
==========================================
- Coverage   80.70%   80.64%   -0.06%     
==========================================
  Files         176      176              
  Lines       15666    15666              
==========================================
- Hits        12643    12634       -9     
- Misses       3023     3032       +9
Flag Coverage Δ
integrationtests 70.80% <ø> (-0.13%) ⬇️
unittests 59.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 87.96% <0.00%> (-1.39%) ⬇️
...ython/feast/embedded_go/online_features_service.py 89.39% <0.00%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e50019c...6a84951. Read the comment docs.

@kevjumba
Copy link
Copy Markdown
Collaborator

kevjumba commented Jun 24, 2022

/lgtm

achals
achals reviewed Jun 24, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we try to move this to cibuildwheel at the same time? Or do we expect this to "just work" after disabling go?

@kevjumba
Copy link
Copy Markdown
Collaborator

kevjumba commented Jun 24, 2022

Should we try to move this to cibuildwheel at the same time? Or do we expect this to "just work" after disabling go?

@achals from our testing I think it should just work, since Felix’s build on his fork worked when gopy was disabled

achals
achals approved these changes Jun 24, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Jun 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit b34ad13 into feast-dev:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes

Assignees

@achals achals

@kevjumba kevjumba

Labels

approved lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@felixwang9817 @codecov-commenter @kevjumba @feast-ci-bot @achals