Skip to content

Commit e50019c

Browse files
achalsachals
authored
chore: Upgrade version of arrow/go (#2856)
Signed-off-by: Achal Shah <achals@gmail.com>
1 parent a3304d4 commit e50019c

File tree

4 files changed

+17
-18
lines changed

4 files changed

+17
-18
lines changed

‎go.mod‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ go 1.17
55
replace github.com/go-python/gopy v0.4.0 => github.com/feast-dev/gopy v0.4.1-0.20220429180328-4257ac71a4d0
66

77
require (
8-
github.com/apache/arrow/go/v8 v8.0.0-20220408212425-58fe60f59289
8+
github.com/apache/arrow/go/v8 v8.0.0
99
github.com/ghodss/yaml v1.0.0
1010
github.com/go-python/gopy v0.4.0
1111
github.com/go-redis/redis/v8 v8.11.4
@@ -40,10 +40,10 @@ require (
4040
golang.org/x/exp v0.0.0-20220407100705-7b9b53b0aca4 // indirect
4141
golang.org/x/mod v0.6.0-dev.0.20220106191415-9b9b3d81d5e3 // indirect
4242
golang.org/x/net v0.0.0-20220407224826-aac1ed45d8e3 // indirect
43-
golang.org/x/sys v0.0.0-20220406163625-3f8b81556e12 // indirect
43+
golang.org/x/sys v0.0.0-20220412211240-33da011f77ad // indirect
4444
golang.org/x/text v0.3.7 // indirect
4545
golang.org/x/tools v0.1.11-0.20220413170336-afc6aad76eb1 // indirect
46-
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 // indirect
46+
golang.org/x/xerrors v0.0.0-20220411194840-2f41105eb62f // indirect
4747
google.golang.org/genproto v0.0.0-20220407144326-9054f6ed7bac // indirect
4848
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c // indirect
4949
gopkg.in/yaml.v2 v2.4.0 // indirect

‎go.sum‎

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ github.com/alecthomas/units v0.0.0-20190717042225-c3de453c63f4/go.mod h1:ybxpYRF
2121
github.com/andybalholm/brotli v1.0.4 h1:V7DdXeJtZscaqfNuAdSRuRFzuiKlHSC/Zh3zl9qY3JY=
2222
github.com/andybalholm/brotli v1.0.4/go.mod h1:fO7iG3H7G2nSZ7m0zPUDn85XEX2GTukHGRSepvi9Eig=
2323
github.com/antihax/optional v1.0.0/go.mod h1:uupD/76wgC+ih3iEmQUL+0Ugr19nfwCT1kdvxnR2qWY=
24-
github.com/apache/arrow/go/v8 v8.0.0-20220408212425-58fe60f59289 h1:nzLohtTu6I/mbr7xjFrMKDk88mkL/Lcp8kVcIITGjaE=
25-
github.com/apache/arrow/go/v8 v8.0.0-20220408212425-58fe60f59289/go.mod h1:UUe+gJaMnuFD6icfGSJxUjG/tX/POUbPS/wE+EFyncM=
24+
github.com/apache/arrow/go/v8 v8.0.0 h1:mG1dDlq8aQO4a/PB00T9H19Ga2imvqoFPHI5cykpibs=
25+
github.com/apache/arrow/go/v8 v8.0.0/go.mod h1:63co72EKYQT9WKr8Y1Yconk4dysC0t79wNDauYO1ZGg=
2626
github.com/apache/thrift v0.12.0/go.mod h1:cp2SuWMxlEZw2r+iP2GNCdIi4C1qmUzdZFSVb+bacwQ=
2727
github.com/apache/thrift v0.13.0/go.mod h1:cp2SuWMxlEZw2r+iP2GNCdIi4C1qmUzdZFSVb+bacwQ=
2828
github.com/apache/thrift v0.15.0 h1:aGvdaR0v1t9XLgjtBYwxcBvBOTMqClzwE26CHOgjW1Y=
@@ -115,7 +115,6 @@ github.com/go-redis/redis/v8 v8.11.4/go.mod h1:2Z2wHZXdQpCDXEGzqMockDpNyYvi2l4Px
115115
github.com/go-sql-driver/mysql v1.4.0/go.mod h1:zAC/RDZ24gD3HViQzih4MyKcchzm+sOG5ZlKdlhCg5w=
116116
github.com/go-stack/stack v1.8.0/go.mod h1:v0f6uXyyMGvRgIKkXu+yp6POWl0qKG85gN/melR3HDY=
117117
github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0/go.mod h1:fyg7847qk6SyHyPtNmDHnmrv/HOrqktSC+C9fM+CJOE=
118-
github.com/goccy/go-json v0.7.10/go.mod h1:6MelG93GURQebXPDq3khkgXZkazVtN9CRI+MGFi0w8I=
119118
github.com/goccy/go-json v0.9.6 h1:5/4CtRQdtsX0sal8fdVhTaiMN01Ri8BExZZ8iRmHQ6E=
120119
github.com/goccy/go-json v0.9.6/go.mod h1:6MelG93GURQebXPDq3khkgXZkazVtN9CRI+MGFi0w8I=
121120
github.com/gogo/googleapis v1.1.0/go.mod h1:gf4bu3Q80BeJ6H1S1vYPm8/ELATdvryBaNFGgqEef3s=
@@ -509,9 +508,8 @@ golang.org/x/sys v0.0.0-20210510120138-977fb7262007/go.mod h1:oPkhp1MJrh7nUepCBc
509508
golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
510509
golang.org/x/sys v0.0.0-20211019181941-9d821ace8654/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
511510
golang.org/x/sys v0.0.0-20211216021012-1d35b9e2eb4e/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
512-
golang.org/x/sys v0.0.0-20220128215802-99c3d69c2c27/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
513-
golang.org/x/sys v0.0.0-20220406163625-3f8b81556e12 h1:QyVthZKMsyaQwBTJE04jdNN0Pp5Fn9Qga0mrgxyERQM=
514-
golang.org/x/sys v0.0.0-20220406163625-3f8b81556e12/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
511+
golang.org/x/sys v0.0.0-20220412211240-33da011f77ad h1:ntjMns5wyP/fN65tdBD4g8J5w8n015+iIIs9rtjXkY0=
512+
golang.org/x/sys v0.0.0-20220412211240-33da011f77ad/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
515513
golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
516514
golang.org/x/term v0.0.0-20210927222741-03fcf44c2211/go.mod h1:jbD1KX2456YbFQfuXm/mYQcufACuNUgVhRMnK/tPxf8=
517515
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
@@ -545,14 +543,15 @@ golang.org/x/tools v0.0.0-20200117012304-6edc0a871e69/go.mod h1:TB2adYChydJhpapK
545543
golang.org/x/tools v0.0.0-20201224043029-2b0845dc783e/go.mod h1:emZCQorbCU4vsT4fOWvOPXz4eW1wZW4PmDk9uLelYpA=
546544
golang.org/x/tools v0.1.0/go.mod h1:xkSsbof2nBLbhDlRMhhhyNLN/zl3eTqcnHD5viDpcZ0=
547545
golang.org/x/tools v0.1.8-0.20211029000441-d6a9af8af023/go.mod h1:nABZi5QlRsZVlzPpHl034qft6wpY4eDcsTt5AaioBiU=
548-
golang.org/x/tools v0.1.9/go.mod h1:nABZi5QlRsZVlzPpHl034qft6wpY4eDcsTt5AaioBiU=
546+
golang.org/x/tools v0.1.10/go.mod h1:Uh6Zz+xoGYZom868N8YTex3t7RhtHDBrE8Gzo9bV56E=
549547
golang.org/x/tools v0.1.11-0.20220413170336-afc6aad76eb1 h1:Z3vE1sGlC7qiyFJkkDcZms8Y3+yV8+W7HmDSmuf71tM=
550548
golang.org/x/tools v0.1.11-0.20220413170336-afc6aad76eb1/go.mod h1:Uh6Zz+xoGYZom868N8YTex3t7RhtHDBrE8Gzo9bV56E=
551549
golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
552550
golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
553551
golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
554-
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 h1:go1bK/D/BFZV2I8cIQd1NKEZ+0owSTG1fDTci4IqFcE=
555552
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
553+
golang.org/x/xerrors v0.0.0-20220411194840-2f41105eb62f h1:GGU+dLjvlC3qDwqYgL6UgRmHXhOOgns0bZu2Ty5mm6U=
554+
golang.org/x/xerrors v0.0.0-20220411194840-2f41105eb62f/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
556555
gonum.org/v1/gonum v0.0.0-20180816165407-929014505bf4/go.mod h1:Y+Yx5eoAFn32cQvJDxZx5Dpnq+c3wtXuadVZAcxbbBo=
557556
gonum.org/v1/gonum v0.8.2/go.mod h1:oe/vMfY3deqTw+1EZJhuvEW2iwGF1bW9wwu7XCu0+v0=
558557
gonum.org/v1/gonum v0.9.3 h1:DnoIG+QAMaF5NvxnGe/oKsgKcAc6PcUyl8q0VetfQ8s=

‎go/embedded/online_features.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -354,13 +354,13 @@ func (s *OnlineFeatureService) StopGrpcServer() {
354354
into Go Arrow Interface (array.Record).
355355
See export code here https://github.com/feast-dev/feast/blob/master/sdk/python/feast/embedded_go/online_features_service.py
356356
*/
357-
func readArrowRecord(data DataTable) (array.Record, error) {
357+
func readArrowRecord(data DataTable) (arrow.Record, error) {
358358
return cdata.ImportCRecordBatch(
359359
cdata.ArrayFromPtr(data.DataPtr),
360360
cdata.SchemaFromPtr(data.SchemaPtr))
361361
}
362362

363-
func recordToProto(rec array.Record) (map[string]*prototypes.RepeatedValue, error) {
363+
func recordToProto(rec arrow.Record) (map[string]*prototypes.RepeatedValue, error) {
364364
r := make(map[string]*prototypes.RepeatedValue)
365365
schema := rec.Schema()
366366
for idx, column := range rec.Columns() {

‎go/internal/feast/transformation/transformation.go‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ func AugmentResponseWithOnDemandTransforms(
4242
var err error
4343

4444
for _, odfv := range onDemandFeatureViews {
45-
requestContextArrow := make(map[string]array.Interface)
45+
requestContextArrow := make(map[string]arrow.Array)
4646
for name, values := range requestData {
4747
requestContextArrow[name], err = types.ProtoValuesToArrowArray(values.Val, arrowMemory, numRows)
4848
if err != nil {
@@ -57,7 +57,7 @@ func AugmentResponseWithOnDemandTransforms(
5757
}
5858
}
5959

60-
retrievedFeatures := make(map[string]array.Interface)
60+
retrievedFeatures := make(map[string]arrow.Array)
6161
for _, vector := range features {
6262
retrievedFeatures[vector.Name] = vector.Values
6363
}
@@ -81,8 +81,8 @@ func AugmentResponseWithOnDemandTransforms(
8181

8282
func CallTransformations(
8383
featureView *model.OnDemandFeatureView,
84-
retrievedFeatures map[string]array.Interface,
85-
requestContext map[string]array.Interface,
84+
retrievedFeatures map[string]arrow.Array,
85+
requestContext map[string]arrow.Array,
8686
callback TransformationCallback,
8787
numRows int,
8888
fullFeatureNames bool,
@@ -106,7 +106,7 @@ func CallTransformations(
106106
outSchemaPtr := uintptr(unsafe.Pointer(&outSchema))
107107

108108
inputFields := make([]arrow.Field, 0)
109-
inputColumns := make([]array.Interface, 0)
109+
inputColumns := make([]arrow.Array, 0)
110110
for name, arr := range retrievedFeatures {
111111
inputFields = append(inputFields, arrow.Field{Name: name, Type: arr.DataType()})
112112
inputColumns = append(inputColumns, arr)

0 commit comments

Comments
 (0)