Skip to content

chore: Rename stream data source parameters - #2804

Merged
feast-ci-bot merged 7 commits into
feast-dev:masterfrom
felixwang9817:stream_data_sources
Jun 17, 2022
Merged

chore: Rename stream data source parameters#2804
feast-ci-bot merged 7 commits into
feast-dev:masterfrom
felixwang9817:stream_data_sources

Conversation

@felixwang9817

@felixwang9817 felixwang9817 commented Jun 16, 2022

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it: This PR renames bootstrap_servers to kafka_bootstrap_servers and watermark to watermark_delay_threshold for KafkaSource. It also deprecates the date_partition_column for all data sources.

Which issue(s) this PR fixes:

Fixes #

kevjumba
kevjumba reviewed Jun 16, 2022
View reviewed changes

@kevjumba kevjumba left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov-commenter

codecov-commenter commented Jun 16, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2804 (fc12f54) into master (19aedc2) will decrease coverage by 0.01%.
The diff coverage is 69.56%.

@@            Coverage Diff             @@
##           master    #2804      +/-   ##
==========================================
- Coverage   80.52%   80.50%   -0.02%     
==========================================
  Files         172      172              
  Lines       15352    15356       +4     
==========================================
+ Hits        12362    12363       +1     
- Misses       2990     2993       +3
Flag Coverage Δ
integrationtests 70.50% <60.86%> (-0.02%) ⬇️
unittests 59.63% <69.56%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...thon/feast/infra/offline_stores/bigquery_source.py 87.50% <ø> (ø)
...k/python/feast/infra/offline_stores/file_source.py 88.07% <ø> (ø)
...thon/feast/infra/offline_stores/redshift_source.py 89.56% <ø> (ø)
...hon/feast/infra/offline_stores/snowflake_source.py 92.37% <ø> (ø)
...on/tests/integration/registration/test_registry.py 94.97% <ø> (ø)
...ion/registration/test_stream_feature_view_apply.py 98.07% <ø> (ø)
sdk/python/tests/unit/test_feature_views.py 98.68% <ø> (ø)
sdk/python/feast/data_source.py 83.33% <68.18%> (-0.37%) ⬇️
sdk/python/tests/unit/test_data_sources.py 100.00% <100.00%> (ø)
...ython/feast/embedded_go/online_features_service.py 89.14% <0.00%> (-0.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19aedc2...fc12f54. Read the comment docs.

@feast-ci-bot feast-ci-bot removed the lgtm label Jun 16, 2022
kevjumba
kevjumba reviewed Jun 16, 2022
View reviewed changes

@kevjumba kevjumba left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot feast-ci-bot added lgtm and removed lgtm labels Jun 16, 2022
achals
achals approved these changes Jun 17, 2022
View reviewed changes
Comment thread sdk/python/feast/data_source.py Outdated
Comment on lines 53 to 56

@achals achals Jun 17, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to worry about backwards compatibility?

@felixwang9817 felixwang9817 Jun 17, 2022

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no for watermark_delay_threshold as this was very recently added by Kevin and has not been part of a release yet

yes for kafka_bootstrap_servers, which I believe I handled appropriately

@feast-ci-bot

feast-ci-bot commented Jun 17, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

achals
achals reviewed Jun 17, 2022
View reviewed changes
Comment thread sdk/python/feast/data_source.py Outdated

@achals achals Jun 17, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
event_timestamp_column: (Deprecated) Event timestamp column used for point in time
event_timestamp_column: (Deprecated in favor of `timestamp_field`) Event timestamp column used for point in time

applies everywhere

@felixwang9817
Deprecate bootstrap_servers parameter in KafkaSource
6589a2e 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
Rename watermark to watermark_delay_threshold for KafkaSource
2580835 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
Deprecate date_partition_column for all data sources
2c97053 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
Fix Java
aafd5e9 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
Fix SparkKafkaProcessor
5d4b055 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
Clarify comment
a882b74 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
More clarifications
fc12f54 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@achals achals mentioned this pull request Jun 17, 2022
Closed
@achals

achals commented Jun 17, 2022

Copy link
Copy Markdown
Member

/lgtm

@achals
achals marked this pull request as draft June 17, 2022 05:08
@achals
achals marked this pull request as ready for review June 17, 2022 05:08
@achals achals added lgtm and removed lgtm labels Jun 17, 2022
@achals achals mentioned this pull request Jun 17, 2022
Closed
@feast-ci-bot
feast-ci-bot merged commit a62a90d into feast-dev:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes
@kevjumba kevjumba kevjumba left review comments

Assignees

@achals achals

@kevjumba kevjumba

Labels

approved lgtm ok-to-test size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@felixwang9817 @codecov-commenter @feast-ci-bot @achals @kevjumba