Skip to content

Commit fc12f54

Browse files
committed
More clarifications
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
1 parent a882b74 commit fc12f54

5 files changed

Lines changed: 12 additions & 10 deletions

File tree

sdk/python/feast/data_source.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -220,8 +220,8 @@ def __init__(
220220
Creates a DataSource object.
221221
Args:
222222
name: Name of data source, which should be unique within a project
223-
event_timestamp_column (optional): (Deprecated) Event timestamp column used for point in time
224-
joins of feature values.
223+
event_timestamp_column (optional): (Deprecated in favor of timestamp_field) Event
224+
timestamp column used for point in time joins of feature values.
225225
created_timestamp_column (optional): Timestamp column indicating when the row
226226
was created, used for deduplicating rows.
227227
field_mapping (optional): A dictionary mapping of column names in this data
@@ -396,8 +396,8 @@ def __init__(
396396
397397
Args:
398398
name: Name of data source, which should be unique within a project
399-
event_timestamp_column: (Deprecated) Event timestamp column used for point in time
400-
joins of feature values.
399+
event_timestamp_column (optional): (Deprecated in favor of timestamp_field) Event
400+
timestamp column used for point in time joins of feature values.
401401
bootstrap_servers: (Deprecated) The servers of the kafka broker in the form "localhost:9092".
402402
kafka_bootstrap_servers: The servers of the kafka broker in the form "localhost:9092".
403403
message_format: StreamFormat of serialized messages.

sdk/python/feast/infra/offline_stores/bigquery_source.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ def __init__(
3737
3838
Args:
3939
table (optional): The BigQuery table where features can be found.
40-
event_timestamp_column: (Deprecated) Event timestamp column used for point in time joins of feature values.
40+
event_timestamp_column (optional): (Deprecated in favor of timestamp_field) Event
41+
timestamp column used for point in time joins of feature values.
4142
created_timestamp_column (optional): Timestamp column when row was created, used for deduplicating rows.
4243
field_mapping: A dictionary mapping of column names in this data source to feature names in a feature table
4344
or view. Only used for feature columns, not entities or timestamp columns.

sdk/python/feast/infra/offline_stores/file_source.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ def __init__(
4444
4545
path: File path to file containing feature data. Must contain an event_timestamp column, entity columns and
4646
feature columns.
47-
event_timestamp_column(optional): (Deprecated) Event timestamp column used for point in time joins of feature values.
47+
event_timestamp_column (optional): (Deprecated in favor of timestamp_field) Event
48+
timestamp column used for point in time joins of feature values.
4849
created_timestamp_column (optional): Timestamp column when row was created, used for deduplicating rows.
4950
file_format (optional): Explicitly set the file format. Allows Feast to bypass inferring the file format.
5051
field_mapping: A dictionary mapping of column names in this data source to feature names in a feature table

sdk/python/feast/infra/offline_stores/redshift_source.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ def __init__(
3939
Creates a RedshiftSource object.
4040
4141
Args:
42-
event_timestamp_column (optional): (Deprecated) Event timestamp column used for point in
43-
time joins of feature values.
42+
event_timestamp_column (optional): (Deprecated in favor of timestamp_field) Event
43+
timestamp column used for point in time joins of feature values.
4444
table (optional): Redshift table where the features are stored.
4545
schema (optional): Redshift schema in which the table is located.
4646
created_timestamp_column (optional): Timestamp column indicating when the

sdk/python/feast/infra/offline_stores/snowflake_source.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ def __init__(
4343
warehouse (optional): Snowflake warehouse where the database is stored.
4444
schema (optional): Snowflake schema in which the table is located.
4545
table (optional): Snowflake table where the features are stored.
46-
event_timestamp_column (optional): (Deprecated) Event timestamp column used for point in
47-
time joins of feature values.
46+
event_timestamp_column (optional): (Deprecated in favor of timestamp_field) Event
47+
timestamp column used for point in time joins of feature values.
4848
query (optional): The query to be executed to obtain the features.
4949
created_timestamp_column (optional): Timestamp column indicating when the
5050
row was created, used for deduplicating rows.

0 commit comments

Comments
 (0)