Skip to content

docs: Fix rtd docs by removing mysqlclient #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adchia merged 3 commits into from
Jun 10, 2022
Merged

docs: Fix rtd docs by removing mysqlclient #2778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37528c6
docs: Fix rtd docs by removing mysqlclient
achals Jun 10, 2022
522059d
fixes
achals Jun 10, 2022
4c3cb2b
rm dockerfile
achals Jun 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .readthedocs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ formats:
- pdf

python:
version: 3.7
version: "3.8"
install:
- requirements: sdk/python/docs/requirements.txt
2 changes: 1 addition & 1 deletion sdk/python/docs/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
-e ".[ci]"
-e ".[docs]"
8 changes: 8 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,13 @@
+ HBASE_REQUIRED
)


# rtd builds fail because of mysql not being installed in their environment.
# We can add mysql there, but it's not strictly needed. This will be faster for builds.
DOCS_REQUIRED = CI_REQUIRED
for _r in MYSQL_REQUIRED:
DOCS_REQUIRED.remove(_r)

DEV_REQUIRED = ["mypy-protobuf==3.1", "grpcio-testing==1.*"] + CI_REQUIRED

# Get git repo root directory
Expand Down Expand Up @@ -480,6 +487,7 @@ def copy_extensions_to_source(self):
"ge": GE_REQUIRED,
"hbase": HBASE_REQUIRED,
"go": GO_REQUIRED,
"docs": DOCS_REQUIRED,
},
include_package_data=True,
license="Apache",
Expand Down