Skip to content

docs: Fix rtd docs by removing mysqlclient - #2778

Merged
adchia merged 3 commits into
feast-dev:masterfrom
achals:achal/docs-fix
Jun 10, 2022
Merged

docs: Fix rtd docs by removing mysqlclient#2778
adchia merged 3 commits into
feast-dev:masterfrom
achals:achal/docs-fix

Conversation

@achals

@achals achals commented Jun 10, 2022

Copy link
Copy Markdown
Member

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@achals
docs: Fix rtd docs by removing mysqlclient
37528c6 
Signed-off-by: Achal Shah <achals@gmail.com>
@codecov-commenter

codecov-commenter commented Jun 10, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2778 (4c3cb2b) into master (4ed107c) will decrease coverage by 20.84%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master    #2778       +/-   ##
===========================================
- Coverage   80.52%   59.68%   -20.85%     
===========================================
  Files         173      173               
  Lines       15146    15149        +3     
===========================================
- Hits        12196     9041     -3155     
- Misses       2950     6108     +3158
Flag Coverage Δ
integrationtests ?
unittests 59.68% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)
.../integration/online_store/test_online_retrieval.py 16.84% <0.00%> (-80.00%) ⬇️
...fline_store/test_universal_historical_retrieval.py 23.80% <0.00%> (-76.20%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 19.35% <0.00%> (-74.20%) ⬇️
.../integration/online_store/test_universal_online.py 17.43% <0.00%> (-73.03%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 28.35% <0.00%> (-71.65%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 27.77% <0.00%> (-71.43%) ⬇️
sdk/python/feast/wait.py 23.52% <0.00%> (-70.59%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
...s/integration/registration/test_universal_types.py 32.25% <0.00%> (-67.75%) ⬇️
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ed107c...4c3cb2b. Read the comment docs.

@achals

achals commented Jun 10, 2022

Copy link
Copy Markdown
Member Author

Actually i think there may be a better way for this. Tomorrow morning

@achals
fixes
522059d 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
rm dockerfile
4c3cb2b 
Signed-off-by: Achal Shah <achals@gmail.com>
adchia
adchia approved these changes Jun 10, 2022
View reviewed changes

@adchia adchia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

feast-ci-bot commented Jun 10, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adchia
adchia merged commit 0439945 into feast-dev:master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adchia adchia adchia approved these changes

Assignees

@adchia adchia

Labels

approved lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@achals @codecov-commenter @feast-ci-bot @adchia