Skip to content

chore: Deprecate value type #2673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 29 commits into from
May 18, 2022
Merged

chore: Deprecate value type #2673

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
39733b2
Switch `entities` from List[str] to List[Entity]
felixwang9817 Apr 25, 2022
a6a675b
Remove `value_type` from SDK
felixwang9817 Apr 26, 2022
10523c7
Remove `value_type` from tests
felixwang9817 Apr 26, 2022
705e952
Deprecate `value_type` parameter for Entity
felixwang9817 May 2, 2022
afbb5dd
Add fields for entities to avoid type inference after removing `value…
felixwang9817 Apr 26, 2022
c66976c
Fix Go
felixwang9817 May 2, 2022
00bb4d8
Fix type inference
felixwang9817 May 3, 2022
bc88d5c
Another fix
felixwang9817 May 3, 2022
a4d8e44
Another fix
felixwang9817 May 3, 2022
3dfa9d6
Rename Entities to EntityNames in go
felixwang9817 May 3, 2022
49b01b4
Rename lookup
felixwang9817 May 3, 2022
ac31bb7
Rename Feature to Field
felixwang9817 May 3, 2022
a2158e7
Clean up inference
felixwang9817 May 3, 2022
aad0805
Refactor
felixwang9817 May 3, 2022
21d7e55
Use old `value_type` attribute if it still exists
felixwang9817 May 3, 2022
dc750e8
Refactor
felixwang9817 May 3, 2022
6432029
Add TODO
felixwang9817 May 4, 2022
9808789
Another fix
felixwang9817 May 11, 2022
6c92dc2
Fix test
felixwang9817 May 11, 2022
2be1e40
Add pytest.ini file to suppress pytest warnings about markers
felixwang9817 May 11, 2022
9b341b7
Fix type test
felixwang9817 May 11, 2022
2ed0384
Fix type test
felixwang9817 May 13, 2022
7c5b80d
Modify entity and feature inference to occur separately and add tests
felixwang9817 May 13, 2022
0f129d3
Lint
felixwang9817 May 13, 2022
18fbb0d
Refactor inference to pass lint
felixwang9817 May 13, 2022
7a32b01
Fix Java
felixwang9817 May 13, 2022
6c4e9d6
Another fix
felixwang9817 May 13, 2022
d23ee23
Fix ODFV repo
felixwang9817 May 17, 2022
8eaa65c
Switch deprecation version from 0.22 to 0.23
felixwang9817 May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix type test 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
  • Loading branch information
@felixwang9817
felixwang9817 committed May 17, 2022
commit 9b341b71e0ccfee3c343b25fb769cf17bf412d92
9 changes: 3 additions & 6 deletions sdk/python/tests/integration/registration/test_universal_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ def get_fixtures(request, environment):
config.feature_is_list,
config.has_empty_list,
data_source,
config.entity_type,
)

return config, data_source, fv
Expand Down Expand Up @@ -149,7 +148,7 @@ def test_entity_inference_types_match(environment, entity_type):
fv.entity_columns = []
fs.apply([fv, entity])

inferred_entity = fs.get_entity(entity.name)
entities = fs.list_entities()
entity_type_to_expected_inferred_entity_type = {
Int32: {Int32, Int64},
Int64: {Int32, Int64},
Expand All @@ -165,7 +164,7 @@ def test_entity_inference_types_match(environment, entity_type):
entity_column = entity_columns[0]
assert (
entity_column.dtype
in entity_type_to_expected_inferred_entity_type[config.entity_type]
in entity_type_to_expected_inferred_entity_type[entity_type]
)


Expand All @@ -188,7 +187,6 @@ def test_feature_get_historical_features_types_match(
config.feature_is_list,
config.has_empty_list,
data_source,
config.entity_type,
)
fs.apply([fv, entity])

Expand Down Expand Up @@ -239,7 +237,6 @@ def test_feature_get_online_features_types_match(
config.feature_is_list,
config.has_empty_list,
data_source,
config.entity_type,
)
fs = environment.feature_store
features = [fv.name + ":value"]
Expand Down Expand Up @@ -283,7 +280,7 @@ def test_feature_get_online_features_types_match(


def create_feature_view(
name, feature_dtype, feature_is_list, has_empty_list, data_source, entity_type
name, feature_dtype, feature_is_list, has_empty_list, data_source, entity_type = Int64,
):
if feature_is_list is True:
if feature_dtype == "int32":
Expand Down