Use old value_type attribute if it still exists

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
feast-dev · feast-ci-bot · May 18, 2022 · Apr 25, 2022 · Apr 26, 2022 · Apr 26, 2022
commit 21d7e55c70a99b50e19f7dbc2b24d4370730a229
@@ -230,6 +230,7 @@ def to_proto(self) -> EntityProto:
 
         spec = EntitySpecProto(
             name=self.name,
+            value_type=self.value_type.value,
             join_key=self.join_key,
             description=self.description,
             tags=self.tags,

@@ -222,7 +222,6 @@ def __init__(
         # here. Conversely, if the user is still using a List[str], they must not have added
         # added entity fields, in which case we can set the `features` attribute directly
         # equal to the schema.
-        # TODO(felixwang9817): Use old value_type if it exists.
         _features: List[Field] = []
         self.entity_columns = []
         if _entities and len(_entities) > 0 and isinstance(_entities[0], str):

@@ -8,6 +8,7 @@
 from feast.field import Field, from_value_type
 from feast.repo_config import RepoConfig
 from feast.types import String
+from feast.value_type import ValueType
 
 
 def update_data_sources_with_inferred_event_timestamp_col(
@@ -96,6 +97,7 @@ def update_feature_views_with_inferred_features_and_entities(
         entities: A list containing entities associated with the feature views.
         config: The config for the current feature store.
     """
+    entity_name_to_entity_map = {e.name: e for e in entities}
     entity_name_to_join_keys_map = {e.name: e.join_keys for e in entities}
     all_join_keys = [
         join_key
@@ -117,10 +119,25 @@ def update_feature_views_with_inferred_features_and_entities(
                 if field.name not in [feature.name for feature in fv.features]:
                     fv.features.append(field)
 
+        # Since the `value_type` parameter has not yet been fully deprecated for
+        # entities, we respect the `value_type` attribute if it still exists.
+        for entity_name in fv.entities:
+            entity = entity_name_to_entity_map[entity_name]
+            if (
+                entity_name
+                not in [entity_column.name for entity_column in fv.entity_columns]
+                and entity.value_type != ValueType.UNKNOWN
+            ):
+                entity_column.append(
+                    Field(
+                        name=entity.join_key, dtype=from_value_type(entity.value_type),
+                    )
+                )
+
         # Handle EFV separately here. Specifically, that means if we have an EFV,
         # we need to add a field to entity_columns.
         if len(fv.entities) == 1 and fv.entities[0] == DUMMY_ENTITY_NAME:
-            fv.entity_columns.append(Field(name=DUMMY_ENTITY_ID, dtype=String,))
+            fv.entity_columns.append(Field(name=DUMMY_ENTITY_ID, dtype=String))
 
         # Run inference if either (a) there are fewer entity fields than expected or
         # (b) there are no feature fields.