Skip to content

[WIP] Move storage configuration to serving - #254

Merged
zhilingc merged 6 commits into
feast-dev:0.3-devfrom
zhilingc:zl/0.3-dev-storage-opts
Oct 7, 2019
Merged

[WIP] Move storage configuration to serving#254
zhilingc merged 6 commits into
feast-dev:0.3-devfrom
zhilingc:zl/0.3-dev-storage-opts

Conversation

@zhilingc

@zhilingc zhilingc commented Oct 6, 2019

Copy link
Copy Markdown
Collaborator

Moving storage configuration from core so that we can alter serving configuration more dynamically.

  • Added RPC for serving to update core with its configuration
  • When changes are made to stores core will update the jobs accordingly
  • Serving reads store config from an external file, changes are hot-reloaded

TODO:

  • Code cleanup
  • Better testing at core
  • Make externalised config for serving optional (maybe)

woop
woop approved these changes Oct 6, 2019
View reviewed changes

@woop woop left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread protos/feast/core/CoreService.proto
@feast-ci-bot

feast-ci-bot commented Oct 6, 2019

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop, zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop woop mentioned this pull request Oct 7, 2019
Closed
@feast-ci-bot

feast-ci-bot commented Oct 7, 2019

Copy link
Copy Markdown
Collaborator

@zhilingc: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
unit-test-core 0fca98e link /test unit-test-core
unit-test-ingestion 0fca98e link /test unit-test-ingestion
unit-test-cli 0fca98e link /test unit-test-cli
unit-test-serving 0fca98e link /test unit-test-serving
unit-test-python-sdk 0fca98e link /test unit-test-python-sdk
integration-test 0fca98e link /test integration-test

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhilingc
zhilingc merged commit 0fca98e into feast-dev:0.3-dev Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woop woop woop approved these changes
@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@pradithya pradithya Awaiting requested review from pradithya
@thirteen37 thirteen37 Awaiting requested review from thirteen37
@tims tims Awaiting requested review from tims

Assignees

No one assigned

Labels

approved do-not-merge/work-in-progress size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhilingc @feast-ci-bot @woop