Skip to content

fix: Schema update #2509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 19 commits into from
Apr 13, 2022
Merged

fix: Schema update #2509

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1802ac4
Fix
kevjumba Apr 7, 2022
5fd414d
Fix
kevjumba Apr 7, 2022
9f677c7
fix lint
kevjumba Apr 7, 2022
2122172
indent fix
kevjumba Apr 7, 2022
53f3439
Fix
kevjumba Apr 11, 2022
d404a4a
Fix lint
kevjumba Apr 12, 2022
f7005d7
Fix lint
kevjumba Apr 12, 2022
a7a7703
Fix go
kevjumba Apr 12, 2022
156b171
Fix tests
kevjumba Apr 13, 2022
512e00f
Fix
kevjumba Apr 13, 2022
8d62f0c
Fix
kevjumba Apr 13, 2022
eb6bf3c
Fix
kevjumba Apr 13, 2022
fba1388
Revert
kevjumba Apr 13, 2022
a25a3b5
fixes
kevjumba Apr 13, 2022
7d073d5
Fix lint
kevjumba Apr 13, 2022
6fcdaff
Fix and clean up
kevjumba Apr 13, 2022
f91d9bd
Lint
kevjumba Apr 13, 2022
a71eaf9
Fix
kevjumba Apr 13, 2022
a8880cf
Patch fix, will change definitions in separate pr
kevjumba Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix 
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
@kevjumba
kevjumba committed Apr 13, 2022
commit eb6bf3c2297f0bf090995205af676234a0a86cad
3 changes: 3 additions & 0 deletions sdk/python/feast/data_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,9 @@ def __eq__(self, other):
else:
return False

def __hash__(self):
return super().__hash__()

@staticmethod
def from_proto(data_source: DataSourceProto):

Expand Down
1 change: 1 addition & 0 deletions sdk/python/feast/feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,6 +679,7 @@ def apply(

for odfv in odfvs_to_update:
for v in odfv.source_request_sources.values():
print(type(v))
Copy link
Copy Markdown
Member

@achals achals Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm?

Copy link
Copy Markdown
Collaborator Author

@kevjumba kevjumba Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

data_sources_set_to_update.add(v)

data_sources_to_update = list(data_sources_set_to_update)
Expand Down
64 changes: 32 additions & 32 deletions sdk/python/tests/integration/feature_repos/repo_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,38 +86,38 @@
[
IntegrationTestRepoConfig(online_store=REDIS_CONFIG),
# GCP configurations
IntegrationTestRepoConfig(
provider="gcp",
offline_store_creator=BigQueryDataSourceCreator,
online_store="datastore",
),
IntegrationTestRepoConfig(
provider="gcp",
offline_store_creator=BigQueryDataSourceCreator,
online_store=REDIS_CONFIG,
),
# AWS configurations
IntegrationTestRepoConfig(
provider="aws",
offline_store_creator=RedshiftDataSourceCreator,
online_store=DYNAMO_CONFIG,
python_feature_server=True,
),
IntegrationTestRepoConfig(
provider="aws",
offline_store_creator=RedshiftDataSourceCreator,
online_store=REDIS_CONFIG,
),
# Snowflake configurations
IntegrationTestRepoConfig(
provider="aws", # no list features, no feature server
offline_store_creator=SnowflakeDataSourceCreator,
online_store=REDIS_CONFIG,
),
# Go implementation for online retrieval
IntegrationTestRepoConfig(
online_store=REDIS_CONFIG, go_feature_server=True,
),
# IntegrationTestRepoConfig(
# provider="gcp",
# offline_store_creator=BigQueryDataSourceCreator,
# online_store="datastore",
# ),
# IntegrationTestRepoConfig(
# provider="gcp",
# offline_store_creator=BigQueryDataSourceCreator,
# online_store=REDIS_CONFIG,
# ),
# # AWS configurations
# IntegrationTestRepoConfig(
# provider="aws",
# offline_store_creator=RedshiftDataSourceCreator,
# online_store=DYNAMO_CONFIG,
# python_feature_server=True,
# ),
# IntegrationTestRepoConfig(
# provider="aws",
# offline_store_creator=RedshiftDataSourceCreator,
# online_store=REDIS_CONFIG,
# ),
# # Snowflake configurations
# IntegrationTestRepoConfig(
# provider="aws", # no list features, no feature server
# offline_store_creator=SnowflakeDataSourceCreator,
# online_store=REDIS_CONFIG,
# ),
# # Go implementation for online retrieval
# IntegrationTestRepoConfig(
# online_store=REDIS_CONFIG, go_feature_server=True,
# ),
]
)
full_repo_configs_module = os.environ.get(FULL_REPO_CONFIGS_MODULE_ENV_NAME)
Expand Down