Skip to content

fix: Schema update #2509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 19 commits into from
Apr 13, 2022
Merged

fix: Schema update #2509

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1802ac4
Fix
kevjumba Apr 7, 2022
5fd414d
Fix
kevjumba Apr 7, 2022
9f677c7
fix lint
kevjumba Apr 7, 2022
2122172
indent fix
kevjumba Apr 7, 2022
53f3439
Fix
kevjumba Apr 11, 2022
d404a4a
Fix lint
kevjumba Apr 12, 2022
f7005d7
Fix lint
kevjumba Apr 12, 2022
a7a7703
Fix go
kevjumba Apr 12, 2022
156b171
Fix tests
kevjumba Apr 13, 2022
512e00f
Fix
kevjumba Apr 13, 2022
8d62f0c
Fix
kevjumba Apr 13, 2022
eb6bf3c
Fix
kevjumba Apr 13, 2022
fba1388
Revert
kevjumba Apr 13, 2022
a25a3b5
fixes
kevjumba Apr 13, 2022
7d073d5
Fix lint
kevjumba Apr 13, 2022
6fcdaff
Fix and clean up
kevjumba Apr 13, 2022
f91d9bd
Lint
kevjumba Apr 13, 2022
a71eaf9
Fix
kevjumba Apr 13, 2022
a8880cf
Patch fix, will change definitions in separate pr
kevjumba Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix go 
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
@kevjumba
kevjumba committed Apr 13, 2022
commit a7a770324523ef3124a5bf77ed42ad248d51642d
4 changes: 2 additions & 2 deletions go/internal/feast/model/ondemandfeatureview.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ func (fs *OnDemandFeatureView) ProjectWithFeatures(featureNames []string) (*OnDe
func (fs *OnDemandFeatureView) GetRequestDataSchema() map[string]types.ValueType_Enum {
schema := make(map[string]types.ValueType_Enum)
for _, requestDataSource := range fs.SourceRequestDataSources {
for fieldName, fieldValueType := range requestDataSource.Schema {
schema[fieldName] = fieldValueType
for _, spec := range requestDataSource.Schema {
Copy link
Copy Markdown
Collaborator

@pyalex pyalex Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

featureSpec is a better name here

Copy link
Copy Markdown
Collaborator

@pyalex pyalex Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or feature. but spec is to vague

Copy link
Copy Markdown
Collaborator Author

@kevjumba kevjumba Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

schema[spec.Name] = spec.ValueType
}
}
return schema
Expand Down